Re: [git pull request] ACPI Processor Aggregator Driver for 2.6.32-rc1

Len Brown
2009-10-05T22:18:57Z

On Mon, 5 Oct 2009, Rafael J. Wysocki wrote:

> On Monday 05 October 2009, Linus Torvalds wrote:
> >
> > On Mon, 5 Oct 2009, Rafael J. Wysocki wrote:
> > >
> > > This thing has already been merged, it appears: and it looks like a
> > > total breakage of rules to me.
> >
> > Well, Len pointed out to me that the NAK is kind of pointless, since it
> > had no constructive alternatives to the issue. So he left it in as
> > documentation, but until the scheduler people can actually _do_ something
> > about the problem, their voice doesn't really matter, does it?
>
> Well, for a patch that was objected to so strongly, I think it didn't get
> enough review from other relevant people before being pushed upstream.

Originally we proposed various "cute" scheduler tricks to solve this
problem. Peter objected strongly to all of them.

So the patch evolved into something quite simple that
doesn't touch the scheduler at all. However, Peter's
objection to the concept never went away.

> It looks like Balbir didn't see it before for one example.

Surprising, since Balbir is presumably in the same group
as Vaidy at IBM, who is well informed on this topic
and this thread.

> It's been lots of time since the patch was originally posted to send it to
> the LKML for discussion and so on and to receive some comments that
> might help to improve it.

There was no more actionable feedback on the patch.
The latest version was checked in in July, and has
been waiting for the 2.6.32 merge window ever since.

I don't claim that any code in Linux is either
perfect or permanent, but I think this driver is
useful and thus deserved to be upstream where it
can be useful to the widest group of customers.

I'll be happy to have it re-written three times
if Linux evolved to supply more sophisticated
features to handle this situation.

> I have no idea why that wasn't done and I suspect
> there was some corporate pressure on Len to push it upstream as quickly as
> possible.

The driver has simply been waiting for the Linux merge window.

cheers,
-Len