From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>,
Joe Perches <joe@perches.com>, Len Brown <lenb@kernel.org>
Subject: [PATCH v2 0/9] PCI, PNP: print resources consistently
Date: Tue, 13 Oct 2009 13:21:55 -0600 [thread overview]
Message-ID: <20091013192040.22336.84876.stgit@bob.kio> (raw)
These enhance %pR so we can print resource types and flags more easily.
This doesn't really add anything (other than a couple new messages
about host bridge apertures), but hopefully it will make things more
consistent and a bit easier to debug. Sample change (with "pci=use_crs"):
-pci 0000:00:03.0: reg 10 32bit mmio: [0xf6000000-0xf6ffffff]
-pci 0000:00:03.0: reg 14 io port: [0x2400-0x24ff]
-pci 0000:00:03.0: reg 18 32bit mmio: [0xf5ff0000-0xf5ff0fff]
-pci 0000:00:03.0: reg 30 32bit mmio pref: [0x000000-0x01ffff]
+pci_root PNP0A03:00: host bridge window [io 0x0000-0x0cff]
+pci_root PNP0A03:00: host bridge window [io 0x0000-0x2cfe]
+pci_root PNP0A03:00: host bridge window [io 0x03b0-0x03bb]
+pci_root PNP0A03:00: host bridge window [io 0x03c0-0x03df]
+pci_root PNP0A03:00: host bridge window [mem 0xf5d00000-0xf6ffffff]
+pci_root PNP0A03:00: host bridge window [mem 0x000a0000-0x000bffff]
+pci 0000:00:03.0: reg 10: [mem 0xf6000000-0xf6ffffff]
+pci 0000:00:03.0: reg 14: [io 0x2400-0x24ff]
+pci 0000:00:03.0: reg 18: [mem 0xf5ff0000-0xf5ff0fff]
+pci 0000:00:03.0: reg 30: [mem 0x00000000-0x0001ffff pref]
Changes from initial post to v2:
- tidied vsprintf stack buffer to shrink and compute size more accurately
(Joe Perches)
- use %pR for decoding, %pr for "raw" (with type and flags) instead of
adding %pRt and %pRf
- split cleanup from printk changes for easier review
I plan some future patches to add more messages and change some dev_dbg()
to dev_info(), so this series is strictly to change the resource formatting.
---
Bjorn Helgaas (9):
vsprintf: fix io/mem resource width
vsprintf: add %pR support for IRQ and DMA resources
vsprintf: add %pR decoding and %pr for raw struct resource
PCI: set IORESOURCE_MEM_64 before printing resource
PCI: trivial bridge resource factorization
PCI: print resources consistently with %pR
x86/PCI: print resources consistently with %pR
ia64/PCI: print resources consistently with %pR
PNP: print resources consistently with %pR
arch/ia64/pci/pci.c | 24 ++++++++++---
arch/x86/pci/acpi.c | 15 ++++++--
arch/x86/pci/i386.c | 13 +++----
drivers/pci/pci.c | 4 +-
drivers/pci/probe.c | 29 +++++-----------
drivers/pci/quirks.c | 2 +
drivers/pci/setup-bus.c | 82 +++++++++++++++++++-------------------------
drivers/pci/setup-res.c | 20 +++++------
drivers/pnp/quirks.c | 13 ++-----
drivers/pnp/resource.c | 10 ++---
drivers/pnp/support.c | 43 +++--------------------
drivers/pnp/system.c | 14 +++-----
lib/vsprintf.c | 87 ++++++++++++++++++++++++++++++++++++++---------
13 files changed, 183 insertions(+), 173 deletions(-)
--
Bjorn
next reply other threads:[~2009-10-13 19:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 19:21 Bjorn Helgaas [this message]
2009-10-13 19:22 ` [PATCH v2 1/9] vsprintf: fix io/mem resource width Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 2/9] vsprintf: add %pR support for IRQ and DMA resources Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 3/9] vsprintf: add %pR decoding and %pr for raw struct resource Bjorn Helgaas
2009-10-13 19:40 ` Joe Perches
2009-10-13 20:07 ` Bjorn Helgaas
2009-10-13 20:32 ` Joe Perches
2009-10-13 19:22 ` [PATCH v2 4/9] PCI: set IORESOURCE_MEM_64 before printing resource Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 5/9] PCI: trivial bridge resource factorization Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 6/9] PCI: print resources consistently with %pR Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 7/9] x86/PCI: " Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 8/9] ia64/PCI: " Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 9/9] PNP: " Bjorn Helgaas
2009-10-14 6:47 ` [PATCH v2 0/9] PCI, PNP: print resources consistently Yinghai Lu
2009-10-14 15:52 ` Bjorn Helgaas
2009-10-22 22:53 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013192040.22336.84876.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox