From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>,
Joe Perches <joe@perches.com>, Len Brown <lenb@kernel.org>
Subject: [PATCH v2 8/9] ia64/PCI: print resources consistently with %pR
Date: Tue, 13 Oct 2009 13:22:35 -0600 [thread overview]
Message-ID: <20091013192235.22336.65357.stgit@bob.kio> (raw)
In-Reply-To: <20091013192040.22336.84876.stgit@bob.kio>
This uses %pR to print additional resource information (type, size,
prefetchability, etc.) consistently.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
arch/ia64/pci/pci.c | 24 +++++++++++++++++++-----
1 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c
index 7de76dd..4704f47 100644
--- a/arch/ia64/pci/pci.c
+++ b/arch/ia64/pci/pci.c
@@ -126,6 +126,7 @@ alloc_pci_controller (int seg)
}
struct pci_root_info {
+ struct acpi_device *bridge;
struct pci_controller *controller;
char *name;
};
@@ -292,9 +293,20 @@ static __devinit acpi_status add_window(struct acpi_resource *res, void *data)
window->offset = offset;
if (insert_resource(root, &window->resource)) {
- printk(KERN_ERR "alloc 0x%llx-0x%llx from %s for %s failed\n",
- window->resource.start, window->resource.end,
- root->name, info->name);
+ dev_err(&info->bridge->dev,
+ "can't allocate host bridge window %pR\n",
+ &window->resource);
+ } else {
+ if (offset)
+ dev_info(&info->bridge->dev, "host bridge window %pR "
+ "(PCI address [%#llx-%#llx])\n",
+ &window->resource,
+ window->resource.start - offset,
+ window->resource.end - offset);
+ else
+ dev_info(&info->bridge->dev,
+ "host bridge window %pR\n",
+ &window->resource);
}
return AE_OK;
@@ -314,8 +326,9 @@ pcibios_setup_root_windows(struct pci_bus *bus, struct pci_controller *ctrl)
(res->end - res->start < 16))
continue;
if (j >= PCI_BUS_NUM_RESOURCES) {
- printk("Ignoring range [%#llx-%#llx] (%lx)\n",
- res->start, res->end, res->flags);
+ dev_warn(&bus->dev,
+ "ignoring host bridge window %pR (no space)\n",
+ res);
continue;
}
bus->resource[j++] = res;
@@ -359,6 +372,7 @@ pci_acpi_scan_root(struct acpi_device *device, int domain, int bus)
goto out3;
sprintf(name, "PCI Bus %04x:%02x", domain, bus);
+ info.bridge = device;
info.controller = controller;
info.name = name;
acpi_walk_resources(device->handle, METHOD_NAME__CRS,
next prev parent reply other threads:[~2009-10-13 19:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 19:21 [PATCH v2 0/9] PCI, PNP: print resources consistently Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 1/9] vsprintf: fix io/mem resource width Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 2/9] vsprintf: add %pR support for IRQ and DMA resources Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 3/9] vsprintf: add %pR decoding and %pr for raw struct resource Bjorn Helgaas
2009-10-13 19:40 ` Joe Perches
2009-10-13 20:07 ` Bjorn Helgaas
2009-10-13 20:32 ` Joe Perches
2009-10-13 19:22 ` [PATCH v2 4/9] PCI: set IORESOURCE_MEM_64 before printing resource Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 5/9] PCI: trivial bridge resource factorization Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 6/9] PCI: print resources consistently with %pR Bjorn Helgaas
2009-10-13 19:22 ` [PATCH v2 7/9] x86/PCI: " Bjorn Helgaas
2009-10-13 19:22 ` Bjorn Helgaas [this message]
2009-10-13 19:22 ` [PATCH v2 9/9] PNP: " Bjorn Helgaas
2009-10-14 6:47 ` [PATCH v2 0/9] PCI, PNP: print resources consistently Yinghai Lu
2009-10-14 15:52 ` Bjorn Helgaas
2009-10-22 22:53 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013192235.22336.65357.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox