From: Alex Chiang <achiang@hp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: lenb@kernel.org, shaohua.li@intel.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 1/6] ACPI: dock: convert sysfs attributes to an attribute_group
Date: Mon, 19 Oct 2009 13:36:15 -0600 [thread overview]
Message-ID: <20091019193615.GC23948@ldl.fc.hp.com> (raw)
In-Reply-To: <20091019175616.GA20992@core.coreip.homeip.net>
* Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>
> If sysfs_create_group() fails you will go to err_unregister:
> which will try to remove the non-existing group. While the
> current sysfs code is relsilient against such errors it may not
> be so in the future. It is better to have a separate label and
> bypass sysfs_remove_group() if sysfs_create_group() returned
> error.
Yeah, you're right. I was trying to be lazy (everyone else is
doing it!), but I guess you won't let me. ;)
I'll respin.
Thanks for the review.
/ac
next prev parent reply other threads:[~2009-10-19 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 21:14 [PATCH v3 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-16 21:14 ` [PATCH v3 1/6] ACPI: dock: convert sysfs attributes to an attribute_group Alex Chiang
2009-10-18 7:16 ` Dmitry Torokhov
2009-10-19 17:21 ` Alex Chiang
2009-10-19 17:56 ` Dmitry Torokhov
2009-10-19 19:36 ` Alex Chiang [this message]
2009-10-16 21:15 ` [PATCH v3 2/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-16 21:15 ` [PATCH v3 3/6] ACPI: dock: remove global 'dock_device_name' Alex Chiang
2009-10-16 21:15 ` [PATCH v3 4/6] ACPI: dock: dock_add - hoist up platform_device_register_simple() Alex Chiang
2009-10-16 21:15 ` [PATCH v3 5/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-16 21:15 ` [PATCH v3 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019193615.GC23948@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox