From: Alex Chiang <achiang@hp.com>
To: =shaohua.li@intel.com, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/6] ACPI: dock: code hygiene
Date: Mon, 19 Oct 2009 15:14:19 -0600 [thread overview]
Message-ID: <20091019211132.5412.80438.stgit@bob.kio> (raw)
This is v4 of a modest attempt to clean up the dock driver.
As before, compile tested only, since I don't have any machines
that provide _DCK.
Thanks.
/ac
v3 -> v4:
- defensively code in case sysfs_create_group() fails and
sysfs_remove_group() can't handle removing a non-existent group;
suggested by Dmitry Torokhov
v2 -> v3:
- now using an attribute_group, as suggested by Dmitry Torokhov
v1 -> v2:
- changed how we add platform device data, based on Shaohua Li's
review
---
Alex Chiang (6):
ACPI: dock: convert sysfs attributes to an attribute_group
ACPI: dock: combine add|alloc_dock_dependent_device
ACPI: dock: remove global 'dock_device_name'
ACPI: dock: dock_add - hoist up platform_device_register_simple()
ACPI: dock: add struct dock_station * directly to platform device data
ACPI: dock: minor whitespace and style cleanups
drivers/acpi/dock.c | 266 ++++++++++++++++++---------------------------------
1 files changed, 93 insertions(+), 173 deletions(-)
next reply other threads:[~2009-10-19 21:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 21:14 Alex Chiang [this message]
2009-10-19 21:14 ` [PATCH v4 1/6] ACPI: dock: convert sysfs attributes to an attribute_group Alex Chiang
2009-10-20 1:38 ` Dmitry Torokhov
2009-10-20 2:57 ` Alex Chiang
2009-10-20 3:26 ` Dmitry Torokhov
2009-10-19 21:14 ` [PATCH v4 2/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-19 21:14 ` [PATCH v4 3/6] ACPI: dock: remove global 'dock_device_name' Alex Chiang
2009-10-19 21:14 ` [PATCH v4 4/6] ACPI: dock: dock_add - hoist up platform_device_register_simple() Alex Chiang
2009-10-19 21:14 ` [PATCH v4 5/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-19 21:14 ` [PATCH v4 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-29 0:07 ` [PATCH v4 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-29 1:00 ` Shaohua Li
2009-11-03 20:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019211132.5412.80438.stgit@bob.kio \
--to=achiang@hp.com \
--cc==shaohua.li@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox