From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v4 1/6] ACPI: dock: convert sysfs attributes to an attribute_group Date: Mon, 19 Oct 2009 20:26:33 -0700 Message-ID: <20091020032632.GI24370@core.coreip.homeip.net> References: <20091019211132.5412.80438.stgit@bob.kio> <20091019211424.5412.15540.stgit@bob.kio> <20091020013844.GB24370@core.coreip.homeip.net> <20091020025733.GA5814@ldl.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f171.google.com ([209.85.216.171]:44347 "EHLO mail-px0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbZJTD0c (ORCPT ); Mon, 19 Oct 2009 23:26:32 -0400 Content-Disposition: inline In-Reply-To: <20091020025733.GA5814@ldl.fc.hp.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alex Chiang Cc: shaohua.li@intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Oct 19, 2009 at 08:57:33PM -0600, Alex Chiang wrote: > * Dmitry Torokhov : > > On Mon, Oct 19, 2009 at 03:14:24PM -0600, Alex Chiang wrote: > > > As suggested by Dmitry Torokhov, convert the individual sysfs > > > attributes into an attribute group. > > > > > > This change eliminates quite a bit of copy/paste code in the > > > error handling paths. > > > > > > > Looks good to me, thank you for making the changes. > > Thank you for your patience along the way. > > Can I count this as an Acked-by? :) > Yes, you may add Reviewed-by: Dmitry Torokhov I use "Acked-by" for stuff I have authority over which is being merged through someone else's tree for one reason or another. Thanks. -- Dmitry