From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Stuart_Hayes@Dell.com
Cc: linux-acpi@vger.kernel.org, Rezwanul_Kabir@Dell.com
Subject: Re: [PATCH] dell-laptop: Use buffer with 32-bit physical address
Date: Thu, 22 Oct 2009 02:57:23 +0100 [thread overview]
Message-ID: <20091022015723.GA14946@srcf.ucam.org> (raw)
In-Reply-To: <DFEF91B22ED07447AB6AA4B237F913F9039D0A64@ausx3mpc125.aus.amer.dell.com>
On Wed, Oct 21, 2009 at 02:04:09PM -0500, Stuart_Hayes@Dell.com wrote:
>
> Calls to communicate with system firmware via a SMI (using dcdbas) need
> to use a buffer that has a physical address of 4GB or less. Currently
> the dell-laptop driver does not guarantee this, and when the buffer
> address is higher than 4GB, the address is truncated to 32 bits and the
> SMI handler writes to the wrong memory address.
>
> Signed-off-by: Stuart Hayes <stuart_hayes@dell.com>
It looks like you've got a printk in there that should be dropped, but
if you resubmit without that then feel free to add
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-10-22 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 19:04 [PATCH] dell-laptop: Use buffer with 32-bit physical address Stuart_Hayes
2009-10-22 1:57 ` Matthew Garrett [this message]
2009-10-22 16:27 ` Stuart_Hayes
2009-10-22 15:12 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2010-02-04 22:56 Matthew Garrett
2010-02-06 15:38 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022015723.GA14946@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Rezwanul_Kabir@Dell.com \
--cc=Stuart_Hayes@Dell.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox