From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] dell-laptop: Use buffer with 32-bit physical address Date: Thu, 22 Oct 2009 02:57:23 +0100 Message-ID: <20091022015723.GA14946@srcf.ucam.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:48526 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753159AbZJVB5Z (ORCPT ); Wed, 21 Oct 2009 21:57:25 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Stuart_Hayes@Dell.com Cc: linux-acpi@vger.kernel.org, Rezwanul_Kabir@Dell.com On Wed, Oct 21, 2009 at 02:04:09PM -0500, Stuart_Hayes@Dell.com wrote: > > Calls to communicate with system firmware via a SMI (using dcdbas) need > to use a buffer that has a physical address of 4GB or less. Currently > the dell-laptop driver does not guarantee this, and when the buffer > address is higher than 4GB, the address is truncated to 32 bits and the > SMI handler writes to the wrong memory address. > > Signed-off-by: Stuart Hayes It looks like you've got a printk in there that should be dropped, but if you resubmit without that then feel free to add Acked-by: Matthew Garrett -- Matthew Garrett | mjg59@srcf.ucam.org