From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v2 0/9] PCI, PNP: print resources consistently Date: Thu, 22 Oct 2009 16:53:52 -0600 Message-ID: <200910221653.53072.bjorn.helgaas@hp.com> References: <20091013192040.22336.84876.stgit@bob.kio> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from g6t0184.atlanta.hp.com ([15.193.32.61]:22303 "EHLO g6t0184.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbZJVWxu (ORCPT ); Thu, 22 Oct 2009 18:53:50 -0400 In-Reply-To: <20091013192040.22336.84876.stgit@bob.kio> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jesse Barnes Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Yinghai Lu , Joe Perches , Len Brown I'm not planning another version of this series because I don't think anybody's raised substantive issues. The only thing I see as a potential issue is the increased stack usage: in resource_string(), the buffer grows from 40 to 73 bytes (64-bit) or 24 to 52 bytes (32-bit). I could imagine using a stack buffer and a mutex for this, but I'm not sure it's worth the code complexity yet. Bjorn