From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [patch] x86: reduce srat verbosity in the kernel log Date: Wed, 28 Oct 2009 00:10:33 +0300 Message-ID: <20091027211033.GN5893@lenovo> References: <20091023233743.439628000@alcatraz.americas.sgi.com> <20091023233750.702443000@alcatraz.americas.sgi.com> <87pr8ay6tc.fsf@basil.nowhere.org> <4AE710C9.2070307@sgi.com> <4AE75162.7080903@sgi.com> <20091027205558.GM5893@lenovo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ew0-f208.google.com ([209.85.219.208]:50769 "EHLO mail-ew0-f208.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932303AbZJ0VKc (ORCPT ); Tue, 27 Oct 2009 17:10:32 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: David Rientjes Cc: Ingo Molnar , Mike Travis , Andi Kleen , Thomas Gleixner , Andrew Morton , Jack Steiner , "H. Peter Anvin" , x86@kernel.org, Yinghai Lu , Mel Gorman , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org [David Rientjes - Tue, Oct 27, 2009 at 02:06:21PM -0700] | On Tue, 27 Oct 2009, Cyrill Gorcunov wrote: | | > | +void __init acpi_numa_print_srat_mapping(void) | > | +{ | > | + int i, j; | > | + | > | + for (i = 0; i < MAX_PXM_DOMAINS; i++) { | > | + int nid; | > | + | > | + nid = pxm_to_node(i); | > | + if (nid == NUMA_NO_NODE) | > | > Btw, David, while you at it, I just curious -- shouldn't we test it | > with NID_INVAL (as pxm_to_node_map initially defined to)? Not a big | > deal at all (since they are both = -1) but for the record. | > Or perhaps I miss something? | > | | I don't think we need to address that since NID_INVAL is going away and | will be replaced by NUMA_NO_NODE since Lee has exposed it globally in his | mempolicy patchset, and as you mention they are the same anyway. | I see. Thanks! -- Cyrill