From: Frans Pop <elendil@planet.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Sujith Thomas <sujith.thomas@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 0/6] [resend] thermal: improvements re. forced passive cooling
Date: Wed, 28 Oct 2009 23:49:04 +0100 [thread overview]
Message-ID: <200910282349.06322.elendil@planet.nl> (raw)
In-Reply-To: <20091028153551.6c665ca1.akpm@linux-foundation.org>
Hi Andrew,
On Wednesday 28 October 2009, Andrew Morton wrote:
> I'm trying to work out what the actual bug is in here.
It turned out there was no bug in the kernel. This patch set is an
enhancement of existing kernel functionality.
> afacit some KDE tool put wrong numbers into /proc files, acpi didn't
> sanity check them sufficiently and permitted the CPU to overheat, yes?
No. The problem was that the thermal zone that overheated did not have a
passive trip point defined in ACPI. So the kernel had no way of knowing
the system was overheating.
The kernel already has an option to "force" a passive trip point for such
zones (using polling to check it), and that works. But while testing that
and looking at the code I spotted some possible enhancements.
> There seems to be rather a lot of non-bugfix stuff in this patch
> series. Perhaps too much for 2.6.32, and a real problem if we want to
> backport something into 2.6.31.x and earlier.
It would have been nice if it had made .32 from my first submission, but
now it's fine for .33. It's not stable material.
Thanks for taking the series.
Cheers,
FJP
next prev parent reply other threads:[~2009-10-28 22:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 7:38 [PATCH 0/6] [resend] thermal: improvements re. forced passive cooling Frans Pop
2009-10-26 7:38 ` [PATCH 1/6] thermal: sysfs-api.txt - reformat for improved readability Frans Pop
2009-11-05 23:11 ` Len Brown
2009-10-26 7:39 ` [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones Frans Pop
2009-11-05 23:11 ` Len Brown
2009-10-26 7:39 ` [PATCH 3/6] acpi: thermal: display forced passive trip points in proc Frans Pop
2009-11-05 23:12 ` Len Brown
2009-10-26 7:39 ` [PATCH 4/6] thermal: add sanity check for the passive attribute Frans Pop
2009-10-26 7:39 ` [PATCH 5/6] thermal: Only set passive_delay for forced_passive cooling Frans Pop
2009-10-26 7:39 ` [PATCH 6/6] thermal: disable polling if passive_delay and polling_delay are both unset Frans Pop
2009-10-28 22:35 ` [PATCH 0/6] [resend] thermal: improvements re. forced passive cooling Andrew Morton
2009-10-28 22:49 ` Frans Pop [this message]
2009-11-05 23:26 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910282349.06322.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rui.zhang@intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox