public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Lutomirski <luto@mit.edu>
Cc: linux-thinkpad@linux-thinkpad.org,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] Set osi=Linux for the ThinkPad X200s
Date: Mon, 9 Nov 2009 16:54:20 +0000	[thread overview]
Message-ID: <20091109165420.GA28672@srcf.ucam.org> (raw)
In-Reply-To: <cb0375e10911090847n4880f048ga0ef68bf41f968c9@mail.gmail.com>

On Mon, Nov 09, 2009 at 11:47:30AM -0500, Andrew Lutomirski wrote:
> The ThinkPad X200s, like the X61, requires OSI=Linux for the mute
> button to work.  Without this patch (or the equivalent command-line
> parameter), the mute button does not generate a keystroke and,
> instead, messes up the sound hardware.

No. How does this work on Windows? Note that we *have* a special driver 
for Thinkpads, and it's entirely acceptable to require it in order to 
have sensible behaviour. We do not want to encourage vendors to 
special-case Linux.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-11-09 16:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 16:47 [PATCH] Set osi=Linux for the ThinkPad X200s Andrew Lutomirski
2009-11-09 16:54 ` Matthew Garrett [this message]
2009-11-09 17:49   ` Andrew Lutomirski
2009-11-09 17:54     ` Matthew Garrett
2009-11-10  9:24       ` [ltp] " Henrique de Moraes Holschuh
2009-11-10 12:42         ` Matthew Garrett
2009-11-10 13:32         ` Andrew Lutomirski
2009-11-10 14:14           ` Matthew Garrett
2009-11-10 17:49           ` Henrique de Moraes Holschuh
2009-11-10  9:19 ` [ltp] " Henrique de Moraes Holschuh
2009-11-25  4:50 ` Len Brown
2009-11-25 17:30   ` Jerone Young
2009-11-25 18:24     ` Len Brown
2009-11-25 19:56       ` Jerone Young
2009-11-26  5:07       ` Matthew Garrett
2009-11-26  6:00         ` Andrew Lutomirski
2009-11-26 17:02           ` Stefan Monnier
2009-11-26 13:43         ` Jerone Young
2009-11-25 19:01   ` Andrew Lutomirski
2009-11-30  5:47   ` Jerone Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091109165420.GA28672@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-thinkpad@linux-thinkpad.org \
    --cc=luto@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox