From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Lutomirski <luto@mit.edu>
Cc: linux-thinkpad@linux-thinkpad.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
ibm-acpi@hmh.eng.br
Subject: Re: [PATCH] Set osi=Linux for the ThinkPad X200s
Date: Mon, 9 Nov 2009 17:54:16 +0000 [thread overview]
Message-ID: <20091109175416.GA29887@srcf.ucam.org> (raw)
In-Reply-To: <cb0375e10911090949o4a51cfd5x4f896d983398a7bc@mail.gmail.com>
On Mon, Nov 09, 2009 at 12:49:56PM -0500, Andrew Lutomirski wrote:
> The Thinkpad mixer is really weird AFAICT. I have no idea how the
> mute button works in Windows with the driver, but I'm not sure that it
> looks like a key press -- I think it does something to the mixer and
> the driver detects it.
When you hit the mixer button, does the ACPI interrupt count increase?
If so, we're certainly in a position to do something with it.
> I actually think the "Linux" behavior makes more sense -- the volume
> up and down buttons already work on all operating systems, and with
> this patch the mute button works the same way.
>
> There's precedent for this hack, and regardless of what we want to
> convince Lenovo to do, making existing hardware work is nice:
> http://bugzilla.kernel.org/show_bug.cgi?id=9907
But it does nothing to solve the underlying issue, and then we get to
apply the same patch again for the next Thinkpad product cycle. If we
fix it properly, we don't need to bother.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-11-09 17:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:47 [PATCH] Set osi=Linux for the ThinkPad X200s Andrew Lutomirski
2009-11-09 16:54 ` Matthew Garrett
2009-11-09 17:49 ` Andrew Lutomirski
2009-11-09 17:54 ` Matthew Garrett [this message]
2009-11-10 9:24 ` [ltp] " Henrique de Moraes Holschuh
2009-11-10 12:42 ` Matthew Garrett
2009-11-10 13:32 ` Andrew Lutomirski
2009-11-10 14:14 ` Matthew Garrett
2009-11-10 17:49 ` Henrique de Moraes Holschuh
2009-11-10 9:19 ` [ltp] " Henrique de Moraes Holschuh
2009-11-25 4:50 ` Len Brown
2009-11-25 17:30 ` Jerone Young
2009-11-25 18:24 ` Len Brown
2009-11-25 19:56 ` Jerone Young
2009-11-26 5:07 ` Matthew Garrett
2009-11-26 6:00 ` Andrew Lutomirski
2009-11-26 17:02 ` Stefan Monnier
2009-11-26 13:43 ` Jerone Young
2009-11-25 19:01 ` Andrew Lutomirski
2009-11-30 5:47 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109175416.GA29887@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-thinkpad@linux-thinkpad.org \
--cc=luto@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox