From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org, robert.moore@intel.com
Subject: Re: [PATCH 1/3] acpi: Provide default GPE handler if the firmware doesn't
Date: Wed, 11 Nov 2009 21:54:04 +0000 [thread overview]
Message-ID: <20091111215404.GA24907@srcf.ucam.org> (raw)
In-Reply-To: <200911112231.58027.rjw@sisk.pl>
On Wed, Nov 11, 2009 at 10:31:57PM +0100, Rafael J. Wysocki wrote:
> Do I think correctly it's based on top of the run-time PM patches?
It's logically distinct, but doesn't really do anything useful without
them.
> > +static acpi_status acpi_pci_pme_notify(void *context)
> > +{
> > + struct work_struct *work = kzalloc(sizeof(struct work_struct),
> > + GFP_ATOMIC);
>
> kzalloc(sizeof(*work), ...) would save you a few characters. :-)
Heh. True.
> > +
> > + if (work) {
> > + INIT_WORK(work, context);
> > + schedule_work(work);
>
> Hmm. Not sure if putting that into pm_wq wouldn't be better.
Would probably work.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2009-11-11 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 22:44 [PATCH 1/3] acpi: Provide default GPE handler if the firmware doesn't Matthew Garrett
2009-11-09 22:44 ` [PATCH 2/3] acpica: Add support for unregistering ACPI GPE methods Matthew Garrett
2009-11-09 22:44 ` [PATCH 3/3] pci: Override gpe 0xd on Dell machines Matthew Garrett
2009-11-11 21:33 ` [PATCH 2/3] acpica: Add support for unregistering ACPI GPE methods Rafael J. Wysocki
2009-11-11 21:31 ` [PATCH 1/3] acpi: Provide default GPE handler if the firmware doesn't Rafael J. Wysocki
2009-11-11 21:54 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111215404.GA24907@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox