From: akpm@linux-foundation.org
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org,
roel.kluin@gmail.com, jwoithe@physics.adelaide.edu.au
Subject: [patch 05/12] fujitsu-laptop: fix tests of acpi_evaluate_integer() return
Date: Tue, 17 Nov 2009 14:27:31 -0800 [thread overview]
Message-ID: <200911172227.nAHMRV26023190@imap1.linux-foundation.org> (raw)
From: Roel Kluin <roel.kluin@gmail.com>
The wrong test was used acpi_status status is unsigned.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/platform/x86/fujitsu-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/platform/x86/fujitsu-laptop.c~fujitsu-laptop-fix-tests-of-acpi_evaluate_integer-return drivers/platform/x86/fujitsu-laptop.c
--- a/drivers/platform/x86/fujitsu-laptop.c~fujitsu-laptop-fix-tests-of-acpi_evaluate_integer-return
+++ a/drivers/platform/x86/fujitsu-laptop.c
@@ -376,7 +376,7 @@ static int get_lcd_level(void)
status =
acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state);
- if (status < 0)
+ if (ACPI_FAILURE(status))
return status;
fujitsu->brightness_level = state & 0x0fffffff;
@@ -398,7 +398,7 @@ static int get_max_brightness(void)
status =
acpi_evaluate_integer(fujitsu->acpi_handle, "RBLL", NULL, &state);
- if (status < 0)
+ if (ACPI_FAILURE(status))
return status;
fujitsu->max_brightness = state;
_
next reply other threads:[~2009-11-17 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:27 akpm [this message]
2009-11-25 5:58 ` [patch 05/12] fujitsu-laptop: fix tests of acpi_evaluate_integer() return Len Brown
2009-11-25 6:29 ` [patch 05/12] fujitsu-laptop: fix tests of acpi_evaluate_integer() Jonathan Woithe
2009-11-25 11:11 ` Roel Kluin
2009-11-26 1:26 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911172227.nAHMRV26023190@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox