From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Frans Pop <elendil@planet.nl>
Cc: akpm@linux-foundation.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, rui.zhang@intel.com
Subject: Re: [patch 08/12] thermal: add sanity check for the passive attribute
Date: Tue, 17 Nov 2009 22:52:04 +0000 [thread overview]
Message-ID: <20091117225204.GB24273@srcf.ucam.org> (raw)
In-Reply-To: <200911172342.58802.elendil@planet.nl>
On Tue, Nov 17, 2009 at 11:42:55PM +0100, Frans Pop wrote:
> On Tuesday 17 November 2009, Matthew Garrett wrote:
> > As noted before, I'm not a fan of this approach - I can't think of many
> > reasons why it'd be necessary to use temperatures below 1 degree C, but
> > this constraint isn't present anywhere else in the thermal code and,
> > really, there's plenty of things that people can break if they just echo
> > incorrect values into /sys.
>
> Personally I'd be in favor of adding more sanity checks rather than
> removing them. The cost of the check is virtually zero.
It makes something that's potentially useful to someone impossible, for
the benefit of people who can crash their system in half a dozen other
ways by writing inappropriate values into other files.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-11-17 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:27 [patch 08/12] thermal: add sanity check for the passive attribute akpm
2009-11-17 22:33 ` Matthew Garrett
2009-11-17 22:42 ` Frans Pop
2009-11-17 22:52 ` Matthew Garrett [this message]
2009-11-17 23:07 ` Frans Pop
2009-11-17 23:12 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117225204.GB24273@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox