From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] Set osi=Linux for the ThinkPad X200s Date: Thu, 26 Nov 2009 05:07:48 +0000 Message-ID: <20091126050748.GA7874@srcf.ucam.org> References: <1259170225.4391.4.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:52942 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbZKZFH4 (ORCPT ); Thu, 26 Nov 2009 00:07:56 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: Jerone Young , Andrew Lutomirski , linux-thinkpad@linux-thinkpad.org, ACPI Devel Maling List On Wed, Nov 25, 2009 at 01:24:50PM -0500, Len Brown wrote: > Have these been verified as necessary to make sound work on > the specified models, or are these speculative patches? To clarify - these patches do *nothing* to make sound work. They change the behaviour of the mute key from changing the hardware state of the mixer and not sending a key event to instead sending a key event and requring that software perform the change. The behavioural change is primarily cosmetic rather than functional. I'm not convinced that this is a sensible thing to do at this point in the release cycle, given that we have no testing of what other behavioural changes the firmware may make. -- Matthew Garrett | mjg59@srcf.ucam.org