Re: rfkill: persistent device suspend/resume

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Sat, 28 Nov 2009, Johannes Berg wrote:
> On Sat, 2009-11-28 at 10:41 -0200, Henrique de Moraes Holschuh wrote:
> > What do you guys think?   I will cook up a patch to implement the above, but
> > if there are any objections to the idea, I'd like to hear it ASAP, as I do
> > have a regression to fix :)
> 
> What part of that don't we do?
> 
> static int rfkill_resume(struct device *dev)
> {
>         struct rfkill *rfkill = to_rfkill(dev);
>         bool cur;
> 
>         if (!rfkill->persistent) {
>                 cur = !!(rfkill->state & RFKILL_BLOCK_SW);
>                 rfkill_set_block(rfkill, cur);
>         }

The issue I am reporting is _only_ about persistent devices, so it is the
if(!rfkill->persistent) that is the problem.  It works perfectly for the
other devices.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh