Re: [PATCH 8/8] thinkpad-acpi: log temperatures on termal alarm

[Pavel Machek <pavel@ucw.cz>]

Hi!

> Log temperatures on any of the EC thermal alarms.  It could be
> useful to help tracking down what is happening...

Thanks, I applied it locally.

>  static bool hotkey_notify_thermal(const u32 hkey,
>  				 bool *send_acpi_ev,
>  				 bool *ignore_acpi_ev)
>  {
> +	int known = true;
> +

Oops?


> +	for (i = 0; i < n; i++)
> +		t.temp[i] = t.temp[i] / 1000;
> +
> +	/* Fill missing sensors with N/A marker */
> +	for (i = n; i < TPACPI_MAX_THERMAL_SENSORS; i++)
> +		t.temp[i] = -128;

-273 would be better "N/A" marker :-).

> +	/* FIXME: it is ugly */
> +	printk(TPACPI_NOTICE
> +		"temperatures (Celsius): "
> +		"%d %d %d %d %d %d %d %d %d %d %d %d %d %d %d %d\n",

But this indeed is ugly. Why not sometihng like

	printk(TPACPI_NOTICE "temperatures (Celsius): ");
	for (i = 0; i < n; i++)
		printk(KERN_CONT "%d ", t.temp[i]);
	printk(KERN_CONT "\n");

...you'd get rid of #ifdef above, ugly -128 markers, and nasty %d series...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html