From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrey Rahmatullin <wrar@altlinux.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 32/33] input: add KEY_WIRELESS_CYCLE
Date: Mon, 7 Dec 2009 14:20:59 +0000 [thread overview]
Message-ID: <20091207142059.GA32617@srcf.ucam.org> (raw)
In-Reply-To: <20091207132334.GG20076@khazad-dum.debian.net>
On Mon, Dec 07, 2009 at 11:23:34AM -0200, Henrique de Moraes Holschuh wrote:
> On Mon, 07 Dec 2009, Matthew Garrett wrote:
> > On Mon, Dec 07, 2009 at 09:47:49AM -0200, Henrique de Moraes Holschuh wrote:
> > > What I do know, is that I will miss a keycode that rfkills just my WLAN... I
> > > use that for power management, it is nice to have a key that is for WLAN
> > > only, and another that is for bluetooth-only...
> >
> > KEY_WLAN will still be there, and you can still remap. But the default
> > behaviour should be for thinkpad-acpi (for instance) to generate
> > KEY_RFKILL, since Fn+F5 isn't supposed to be wlan only.
>
> That's not what I got from this thread. What I got was that KEY_WLAN would
> be overloaded with KEY_RFKILL semanthics, regardless of anything we did in
> the kernel side.
No.
> I am strongly with you here: add a *new* KEY_RFKILL, fix the kernel drivers
> and any eventual userspace to use the new KEY_RFKILL, and have KEY_WLAN do
> what it is supposed to do.
Right. That's what the patch I sent does.
> And, if what we call KEY_WLAN is actually supposed to be KEY_RFKILL, swap
> their definitions when adding KEY_RFKILL, so that USB HID devices will
> generate KEY_RFKILL instead of KEY_WLAN.
I don't think this is in HID?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-12-07 14:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 7:44 [PATCH 00/33] acpi4asus updates for 2.6.33 Corentin Chary
2009-12-03 7:44 ` [PATCH 01/33] eeepc-laptop: disp attribute should be write-only Corentin Chary
2009-12-03 7:44 ` [PATCH 02/33] asus-laptop: Remove redundant NULL checks Corentin Chary
2009-12-03 7:44 ` [PATCH 03/33] asus-acpi: " Corentin Chary
2009-12-03 7:44 ` [PATCH 04/33] asus-laptop: Remove uneccesary acpi_disabled check Corentin Chary
2009-12-03 7:44 ` [PATCH 05/33] asus-acpi: Remove uneccesary acpi_disabled checks Corentin Chary
2009-12-03 7:44 ` [PATCH 06/33] asus-acpi: set acpi_driver.owner Corentin Chary
2009-12-03 7:44 ` [PATCH 07/33] asus-laptop: " Corentin Chary
2009-12-03 7:44 ` [PATCH 08/33] eeepc-laptop: add touchpad led Corentin Chary
2009-12-03 7:44 ` [PATCH 09/33] eeepc-laptop: Remove redundant NULL checks Corentin Chary
2009-12-03 7:44 ` [PATCH 10/33] eeepc-laptop: Remove uneccesary acpi_disabled check Corentin Chary
2009-12-03 7:44 ` [PATCH 11/33] eeepc-laptop: set acpi_driver.owner Corentin Chary
2009-12-03 7:44 ` [PATCH 12/33] eeepc-laptop: fix value of pwm1_enable to match documentation Corentin Chary
2009-12-03 7:44 ` [PATCH 13/33] eeepc-laptop: fix led initialization order Corentin Chary
2009-12-03 7:44 ` [PATCH 14/33] eeepc-laptop: fix potential leak (led_init() failure) Corentin Chary
2009-12-03 7:44 ` [PATCH 15/33] eeepc-laptop: fix set_acpi() to return non-zero on failure Corentin Chary
2009-12-03 7:45 ` [PATCH 16/33] eeepc-laptop: remove redundant NULL checks Corentin Chary
2009-12-03 7:45 ` [PATCH 17/33] eeepc-laptop: no need to check argument of set_brightness() Corentin Chary
2009-12-03 7:45 ` [PATCH 18/33] eeepc-laptop: simplify acpi initialization Corentin Chary
2009-12-03 7:45 ` [PATCH 19/33] eeepc-laptop: simplify how the hwmon device reads values from the EC Corentin Chary
2009-12-03 7:45 ` [PATCH 20/33] eeepc-laptop: refactor notifications Corentin Chary
2009-12-03 7:45 ` [PATCH 21/33] eeepc-laptop: move platform driver registration out of eeepc_hotk_add() Corentin Chary
2009-12-03 7:45 ` [PATCH 22/33] eeepc-laptop: move platform device initialisation to a separate function Corentin Chary
2009-12-03 7:45 ` [PATCH 23/33] eeepc-laptop: code movement Corentin Chary
2009-12-03 7:45 ` [PATCH 24/33] eeepc-laptop: revise names Corentin Chary
2009-12-03 7:45 ` [PATCH 25/33] eeepc-laptop: callbacks should use "driver data" parameter or field Corentin Chary
2009-12-03 7:45 ` [PATCH 26/33] asus-laptop: use KEY_F13 to map "Disable Touchpad" event Corentin Chary
2009-12-03 7:45 ` [PATCH 27/33] asus-laptop: add Lenovo SL hotkey support Corentin Chary
2009-12-03 7:45 ` [PATCH 28/33] asus-laptop: Add wlan switch found on V6V Corentin Chary
2009-12-03 7:45 ` [PATCH 29/33] eeepc-laptop: map keys found on newer eeepc Corentin Chary
2009-12-03 7:45 ` [PATCH 30/33] eeepc-laptop: fix coding style Corentin Chary
2009-12-03 7:45 ` [PATCH 31/33] eeepc-laptop: re-add check for eeepc->backlight == NULL Corentin Chary
2009-12-03 7:45 ` [PATCH 32/33] input: add KEY_WIRELESS_CYCLE Corentin Chary
2009-12-03 7:45 ` [PATCH 33/33] asus-laptop: schedule display_get and lcd_switch for removal Corentin Chary
2009-12-03 7:54 ` [PATCH 32/33] input: add KEY_WIRELESS_CYCLE Dmitry Torokhov
2009-12-03 8:12 ` Corentin Chary
2009-12-03 8:21 ` Dmitry Torokhov
2009-12-03 8:51 ` Corentin Chary
2009-12-03 8:57 ` Dmitry Torokhov
2009-12-03 9:22 ` Corentin Chary
2009-12-03 9:43 ` Johannes Berg
[not found] ` <1259833412.12843.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-12-03 11:23 ` [Kde-hardware-devel] " Will Stephenson
2009-12-03 15:01 ` Matthew Garrett
2009-12-06 6:58 ` Andrey Rahmatullin
2009-12-06 7:17 ` Dmitry Torokhov
2009-12-06 8:21 ` Corentin Chary
2009-12-06 14:54 ` Matthew Garrett
2009-12-07 11:47 ` Henrique de Moraes Holschuh
2009-12-07 12:55 ` Matthew Garrett
2009-12-07 13:23 ` Henrique de Moraes Holschuh
2009-12-07 14:20 ` Matthew Garrett [this message]
2009-12-07 17:02 ` Henrique de Moraes Holschuh
2009-12-03 10:54 ` Henrique de Moraes Holschuh
2009-12-09 21:04 ` [PATCH 00/33] acpi4asus updates for 2.6.33 Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207142059.GA32617@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=corentin.chary@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=wrar@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox