From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Ike Panhc <ike.pan@canonical.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
Corentin Chary <corentin.chary@gmail.com>,
Alexandre Rostovtsev <tetromino@gmail.com>
Subject: Re: [Resend] [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support
Date: Tue, 8 Dec 2009 15:41:54 +0000 [thread overview]
Message-ID: <20091208154154.GA26435@srcf.ucam.org> (raw)
In-Reply-To: <1260257829-7343-1-git-send-email-ike.pan@canonical.com>
On Tue, Dec 08, 2009 at 03:37:09PM +0800, Ike Panhc wrote:
> ASUS_HANDLE(rled_set, ASUS_HOTK_PREFIX "RLED"); /* W1JC */
> ASUS_HANDLE(pled_set, ASUS_HOTK_PREFIX "PLED"); /* A7J */
> ASUS_HANDLE(gled_set, ASUS_HOTK_PREFIX "GLED"); /* G1, G2 (probably) */
The driver is controlling the ATKD device, which has a HID of ATK0101.
These devices are all underneath it...
> +ASUS_HANDLE(lled_set, "\\_SB_.PCI0.SBRG.EC0_.HKEY.TVLS"); /* LenovoCare */
And this one isn't, which is a bit jarring. Looking closer, it's under
the LEN0014 device, which means that you're trying to touch a method
that belongs to a device other than the one this driver is bound to.
That's wrong. You want a separate ACPI driver for the LEN0014 device,
and this should be called for there. Looking at it, you seem to get
rfkill as well (the GWAN/SWAN, GBDC/SBDF and GUWB/SUWB methods) and
maybe some other stuff.
So this shouldn't go in asus-laptop. You'll need to add another separate
driver for the SL-specific functionality.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-12-08 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 7:37 [Resend] [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support Ike Panhc
[not found] ` <1260257829-7343-1-git-send-email-ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2009-12-08 7:43 ` Corentin Chary
2009-12-08 7:51 ` Ike Panhc
2009-12-08 15:41 ` Matthew Garrett [this message]
2009-12-08 17:32 ` Corentin Chary
2009-12-09 6:53 ` Ike Panhc
2009-12-09 7:47 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208154154.GA26435@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=ike.pan@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox