Re: [PATCH 1/2] input: Allow filtering of i8042 events

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Matthew,

On Wed, Dec 09, 2009 at 01:33:28PM -0500, Matthew Garrett wrote:
> Some hardware (such as Dell laptops) signal a variety of events through the
> i8042 controller, even if these don't map to keyboard events. Add support
> for drivers to filter the i8042 event stream in order to respond to these
> events and (if appropriate) block them from entering the input stream.
> 

This is certainly going in the direction I wanted but it looks like
it is more complex than it needs to be. Why don't you just allow
installing global filter for entire i8042 (pass the status register
there along with data byte)? The data you are interested in goes kind of
"ouside" KBD/AUX port abstraction anyway...  Plus currently you are not
handling MUX case properly.

Also I don't think you need to handle the case when we install the same
filter twice? Just always return -EBUSY if there is a filter already and
let drivers keep track of their own stuff and not register tehir filters
twice.

Thanks.

-- 
Dmitry