From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 1/2] input: Allow filtering of i8042 events Date: Wed, 9 Dec 2009 20:16:20 +0000 Message-ID: <20091209201620.GA25133@srcf.ucam.org> References: <1260383609-7681-1-git-send-email-mjg@redhat.com> <20091209200614.GA10138@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:60235 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbZLIURb (ORCPT ); Wed, 9 Dec 2009 15:17:31 -0500 Content-Disposition: inline In-Reply-To: <20091209200614.GA10138@core.coreip.homeip.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org On Wed, Dec 09, 2009 at 12:06:15PM -0800, Dmitry Torokhov wrote: > This is certainly going in the direction I wanted but it looks like > it is more complex than it needs to be. Why don't you just allow > installing global filter for entire i8042 (pass the status register > there along with data byte)? The data you are interested in goes kind of > "ouside" KBD/AUX port abstraction anyway... Plus currently you are not > handling MUX case properly. Wouldn't that require me to be able to process any conceivable mouse protocol as well? -- Matthew Garrett | mjg59@srcf.ucam.org