From: Pavel Machek <pavel@ucw.cz>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Ike Panhc <ike.pan@canonical.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
Alexandre Rostovtsev <tetromino@gmail.com>
Subject: Re: [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support
Date: Thu, 10 Dec 2009 11:14:23 +0100 [thread overview]
Message-ID: <20091210101423.GF2446@ucw.cz> (raw)
In-Reply-To: <71cd59b00912100238l7fe78abcrd07328c15b65971d@mail.gmail.com>
On Thu 2009-12-10 11:38:00, Corentin Chary wrote:
> On Thu, Dec 10, 2009 at 11:09 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Tue 2009-12-08 15:26:09, Ike Panhc wrote:
> >> From: Ike Panhc <ikepanhc@canonical.com>
> >>
> >> This patch is to enable the LenovoCare LED support on Lenovo SL laptop. Based
> >> on the found of the control interface by Alexandre Rostovtsev
> >>
> >> Turn on the LenovoCare LED:
> >> (As root privileges) echo 1 > /sys/class/leds/asus\:\:LenovoCare/brightness
> >> Trun off the LenovoCare LED:
> >> (As root privileges) echo 0 > /sys/class/leds/asus\:\:LenovoCare/brightness
> >>
> >> The patch against current checkout of acpi4asus is below.
> >
> > Is the driver severely misnamed by now? I believe Lenovo and ASUS are
> > pretty different firms...
> >
>
> Lenovo ship DSDT with similar ATKD interace.
> See http://git.iksaif.net/?p=acpi4asus.git;a=commitdiff;h=31a38147625c283b58137db45e7507cd1e49aa05
>
So what? Rename the driver... having Asus::lenovocare led is just wrong.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-12-10 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 7:26 [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support Ike Panhc
[not found] ` <1260257169-7227-1-git-send-email-ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2009-12-10 10:09 ` Pavel Machek
2009-12-10 10:38 ` Corentin Chary
2009-12-10 10:14 ` Pavel Machek [this message]
2009-12-10 10:58 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210101423.GF2446@ucw.cz \
--to=pavel@ucw.cz \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=ike.pan@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox