From: Thomas Renninger <trenn@suse.de>
To: Anisse Astier <anisse@astier.eu>
Cc: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Len Brown <lenb@kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Matt Chen <machen@novell.com>
Subject: Re: [PATCH 0/7] msi-wmi driver and cleanups
Date: Thu, 10 Dec 2009 16:18:27 +0100 [thread overview]
Message-ID: <200912101618.28865.trenn@suse.de> (raw)
In-Reply-To: <1260451099-25620-1-git-send-email-anisse@astier.eu>
Hi Anisse,
thanks for these!
A quick comment on each:
> Anisse Astier (6):
> msi-wmi: remove useless includes
-> good catch, I probably C&P it from another acpi file.
> msi-wmi: rework init
-> might look a bit nicer now, thanks.
> msi-wmi: remove custom runtime debug implementation
-> fine.
> msi-wmi: remove unused field 'instance' in key_entry structure
-> nice cleanup
> msi-wmi: replace one-condition switch-case with if statement
-> might be nicer
> msi-wmi: switch to using input sparse keymap library
-> I didn't go into detail, but this looks like a very nice
cleanup and code reduction.
Thanks,
Thomas
>
> Thomas Renninger (1):
> X86 drivers: Introduce msi-wmi driver
>
> drivers/platform/x86/Kconfig | 11 ++
> drivers/platform/x86/Makefile | 1 +
> drivers/platform/x86/msi-wmi.c | 286 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 298 insertions(+), 0 deletions(-)
> create mode 100644 drivers/platform/x86/msi-wmi.c
>
>
next prev parent reply other threads:[~2009-12-10 15:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 13:18 [PATCH 0/7] msi-wmi driver and cleanups Anisse Astier
2009-12-10 13:18 ` [PATCH 1/7] X86 drivers: Introduce msi-wmi driver Anisse Astier
2009-12-12 17:37 ` Alan Jenkins
2009-12-12 19:21 ` Anisse Astier
2009-12-14 9:55 ` Anisse Astier
2009-12-14 11:31 ` Alan Jenkins
2009-12-16 17:44 ` Len Brown
2009-12-17 10:28 ` [PATCH] MAINTAINERS: add maintainer for " Anisse Astier
2009-12-23 7:26 ` Len Brown
2009-12-10 13:18 ` [PATCH 2/7] msi-wmi: remove useless includes Anisse Astier
2009-12-10 13:18 ` [PATCH 3/7] msi-wmi: rework init Anisse Astier
2009-12-10 13:18 ` [PATCH 4/7] msi-wmi: remove custom runtime debug implementation Anisse Astier
2009-12-10 13:18 ` [PATCH 5/7] msi-wmi: remove unused field 'instance' in key_entry structure Anisse Astier
2009-12-10 13:18 ` [PATCH 6/7] msi-wmi: replace one-condition switch-case with if statement Anisse Astier
2009-12-10 13:18 ` [PATCH 7/7] msi-wmi: switch to using input sparse keymap library Anisse Astier
2009-12-10 15:18 ` Thomas Renninger [this message]
2009-12-10 18:07 ` [PATCH 0/7] msi-wmi driver and cleanups Anisse Astier
2009-12-10 17:47 ` Dmitry Torokhov
2009-12-10 18:14 ` Anisse Astier
2009-12-14 11:34 ` [PATCH 8/7] msi-wmi: depend on backlight and fix corner-cases problems Anisse Astier
2009-12-15 9:55 ` [PATCH 0/7] msi-wmi driver and cleanups Anisse Astier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912101618.28865.trenn@suse.de \
--to=trenn@suse.de \
--cc=anisse@astier.eu \
--cc=carlos@strangeworlds.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=machen@novell.com \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox