Re: [PATCH 0/7] msi-wmi driver and cleanups

Thomas Renninger
2009-12-10T15:18:27Z

Hi Anisse,

thanks for these!
A quick comment on each:

> Anisse Astier (6):
> msi-wmi: remove useless includes
-> good catch, I probably C&P it from another acpi file.
> msi-wmi: rework init
-> might look a bit nicer now, thanks.
> msi-wmi: remove custom runtime debug implementation
-> fine.
> msi-wmi: remove unused field 'instance' in key_entry structure
-> nice cleanup
> msi-wmi: replace one-condition switch-case with if statement
-> might be nicer
> msi-wmi: switch to using input sparse keymap library
-> I didn't go into detail, but this looks like a very nice
cleanup and code reduction.

Thanks,

Thomas
>
> Thomas Renninger (1):
> X86 drivers: Introduce msi-wmi driver
>
> drivers/platform/x86/Kconfig | 11 ++
> drivers/platform/x86/Makefile | 1 +
> drivers/platform/x86/msi-wmi.c | 286 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 298 insertions(+), 0 deletions(-)
> create mode 100644 drivers/platform/x86/msi-wmi.c
>
>