Re: [PATCH 0/7] msi-wmi driver and cleanups

Anisse Astier
2009-12-10T18:09:53Z

Hi Thomas,

On Thu, 10 Dec 2009 16:18:27 +0100, Thomas Renninger <trenn@suse.de> wrote :

> Hi Anisse,
>
> thanks for these!
> A quick comment on each:
>
> > Anisse Astier (6):
> > msi-wmi: remove useless includes
> -> good catch, I probably C&P it from another acpi file.
> > msi-wmi: rework init
> -> might look a bit nicer now, thanks.
> > msi-wmi: remove custom runtime debug implementation
> -> fine.
> > msi-wmi: remove unused field 'instance' in key_entry structure
> -> nice cleanup
> > msi-wmi: replace one-condition switch-case with if statement
> -> might be nicer
> > msi-wmi: switch to using input sparse keymap library
> -> I didn't go into detail, but this looks like a very nice
> cleanup and code reduction.
>

Thanks for taking the time to check this out.

Anisse