public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Youquan,Song" <youquan.song@linux.intel.com>
Cc: lenb@kernel.org, venkatesh.pallipadi@intel.com,
	kent.liu@intel.com, chaohong.guo@intel.com,
	youquan.song@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH]acpi c-states: Fix ACPI C3 is wrongly mapped to C2
Date: Sun, 13 Dec 2009 09:43:17 +0100	[thread overview]
Message-ID: <20091213084317.GA15989@isilmar.linta.de> (raw)
In-Reply-To: <20091212235549.GA7753@youquan-linux.bj.intel.com>

On Sat, Dec 12, 2009 at 06:55:49PM -0500, Youquan,Song wrote:
> On Sat, Dec 12, 2009 at 03:27:27PM +0100, Dominik Brodowski wrote:
> > On Sat, Dec 12, 2009 at 01:14:42PM -0500, Youquan,Song wrote:
> > > On Nehalem-EX, CPU C3 is mapped to ACPI C3, but C-states information in /proc
> > >  and /sys are conflicting with ACPI C2 mapping and confused user.
> > 
> > Well, isn't the "type" only losely related to the C-state number anyway, if
> > you have more than 3 states?
> 
> That's true, if CPU has more 3 states such as C3, C6, C7, there are
> all mapped to ACPI C3.   But the current situation is that if platform
> does NOT support ACPI C2, the user interface /sys show us ACPI C2 is
>  supported which actual is ACPI C3.
> 
> As you know, ACPI C3 and ACPI C2 have much different, such as: BUS SNOOP
>  or not, ACPI C3 has better power saving etc. we should not mix them.

Yes, but what happens if there are two states of type C2? The whole concept
of "type C<number>" and "state C<number>" was broken from the beginning...

Best,
	Dominik

  reply	other threads:[~2009-12-13  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12 18:14 [PATCH]acpi c-states: Fix ACPI C3 is wrongly mapped to C2 Youquan,Song
2009-12-12 14:27 ` Dominik Brodowski
2009-12-12 23:55   ` Youquan,Song
2009-12-13  8:43     ` Dominik Brodowski [this message]
2009-12-14 10:02       ` Youquan,Song
2009-12-14  8:13         ` Dominik Brodowski
2009-12-14 13:12         ` Youquan,Song
2009-12-14 19:12           ` Pallipadi, Venkatesh
2009-12-16  9:28 ` Len Brown
2009-12-17 11:19   ` Youquan,Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091213084317.GA15989@isilmar.linta.de \
    --to=linux@dominikbrodowski.net \
    --cc=chaohong.guo@intel.com \
    --cc=kent.liu@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=youquan.song@intel.com \
    --cc=youquan.song@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox