Re: Async suspend-resume patch w/ completions (was: Re: Async suspend-resume patch w/ rwsems)

Rafael J. Wysocki
2009-12-19T23:39:17Z

On Sunday 20 December 2009, Linus Torvalds wrote:
>
> On Sun, 20 Dec 2009, Rafael J. Wysocki wrote:
> >
> > Well, I guess this is the example of the off-tree dependencies that actually
> > matter Linus wanted. :-)
>
> It's also the kind of dependency where I say "if we get into these kinds
> of messes, then the whole async crap isn't worth it".
>
> Really. Having to try to match things up with ACPI and PnP is a nightmare.
> Especially since I doubt Windows does anything like this, which means that
> there's no reason for BIOS vendors to do the tables so that we'd even
> know.

OK, so this means we can just forget about suspending/resuming i8042
asynchronously, which is a pity, because that gave us some real suspend
speedup on my test systems.

Well, whatever.

So, seriously, do you think it makes sense to do asynchronous suspend at all?
I'm asking, because we're likely to get into troubles like this during suspend
for other kinds of devices too and without resolving them we won't get any
significant speedup from asynchronous suspend.

That said, to me it's definitely worth doing asynchronous resume with the
"start asynch threads upfront" modification, as the results of the tests show
that quite clearly. I hope you agree.

Rafael