From: Mattia Dongili <malattia@linux.it>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] sony-laptop - switch from workqueue to a timer
Date: Fri, 18 Dec 2009 07:46:09 +0900 [thread overview]
Message-ID: <20091217224609.GB13295@kamineko.org> (raw)
In-Reply-To: <20091217080907.GA12790@core.coreip.homeip.net>
On Thu, Dec 17, 2009 at 12:09:07AM -0800, Dmitry Torokhov wrote:
> The function that is executing in workqueue context does not need
> to sleep so let's switch to a timer which is more lightweight.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
>
> Mattia,
>
> After looking at the sony-laptop driver again I realized that since
> we don't sleep in do_sony_laptop_release_key() we don't need to use
> workqueue but can simply fire up a timer.
>
> Please consider applying (or maybe folding into the other patch
> removing private workqueue).
Hi Dmitry,
it looks like there is a bit of other clean-ups here and there included
in this patch, do you mind if I split it (or sending two separate
patches if you get around it before I do this weekend)?
Thanks
--
mattia
:wq!
next prev parent reply other threads:[~2009-12-17 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 8:09 [PATCH] sony-laptop - switch from workqueue to a timer Dmitry Torokhov
2009-12-17 22:46 ` Mattia Dongili [this message]
2009-12-18 6:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217224609.GB13295@kamineko.org \
--to=malattia@linux.it \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox