Re: Regression in module wmi since 2.6.32 (bisected to commit 1caab3c)

Dmitry Torokhov
2009-12-26T01:36:32Z

Hi Carlos,

On Sat, Dec 26, 2009 at 01:18:26AM +0000, Carlos Corbacho wrote:
> @@ -747,6 +763,16 @@ static __init acpi_status parse_wdg(acpi_handle handle)
> memcpy(gblock, obj->buffer.pointer, obj->buffer.length);
>
> for (i = 0; i < total; i++) {
> + /*
> + Some WMI devices, like those for nVidia hooks, have a
> + duplicate GUID. It's not clear what we should do in this
> + case yet, so for now, we'll just ignore the duplicate.
> + Anyone who wants to add support for that device can come
> + up with a better workaround for the mess then.
> + */
> + if (guid_already_parsed(gblock[i].guid) == true) {

A warning message is probably warranted here.

> + continue;
> + }
> wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL);
> if (!wblock)
> return AE_NO_MEMORY;

--
Dmitry