From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: kernel problem 2.6.33-rc2 Date: Sun, 27 Dec 2009 20:16:23 -0800 Message-ID: <20091227201623.07e71915.randy.dunlap@oracle.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Len Brown Cc: werner , Linux Kernel Mailing List , linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, 25 Dec 2009 23:18:57 -0500 (EST) Len Brown wrote: > > dell_wmi_init > > Please try this patch. > > From d11e073ee3e3091d9190dace97ce480e960cca1b Mon Sep 17 00:00:00 2001 > From: Len Brown > Date: Fri, 25 Dec 2009 23:14:26 -0500 > Subject: [PATCH] Revert "wmi: Free the allocated acpi objects through wmi_get_event_data" > X-Patchwork-Hint: ignore > > This reverts commit 3e9b988e4edf065d39c1343937f717319b1c1065. > > Reported-by: Sedat Dilek > Tested-by Maciej Rutecki > Signed-off-by: Len Brown > --- > drivers/platform/x86/dell-wmi.c | 1 - > drivers/platform/x86/hp-wmi.c | 2 -- > drivers/platform/x86/wmi.c | 4 ++-- > 3 files changed, 2 insertions(+), 5 deletions(-) > diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c > index 9f93d6c..e425a86 100644 > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -540,8 +540,8 @@ EXPORT_SYMBOL_GPL(wmi_remove_notify_handler); > /** > * wmi_get_event_data - Get WMI data associated with an event > * > - * @event: Event to find > - * @out: Buffer to hold event data. out->pointer should be freed with kfree() > + * @event - Event to find > + * &out - Buffer to hold event data The '+' kernel-doc formatting is incorrect. Needs to use ':'s and @out. > * > * Returns extra data associated with an event in WMI. > */ --- ~Randy