Re: [PATCH 1/2] dell-wmi - properly handle errors returned by wmi_install_notify_handler()

Dmitry Torokhov
2009-12-29T09:22:04Z

On Tue, Dec 29, 2009 at 09:57:06AM +0100, Paul Rolland wrote:
> Hello,
>
> On Tue, 29 Dec 2009 00:34:14 -0800
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> > wmi_install_notify_handler() retruns ACPI error codes instead of standard
> > Exxxx error codes and they should not be propagated unchanged to the upper
> > layers.
> >
> > Reported-by: Paul Rolland <rol@as2917.net>
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> Tested-by: Paul Rolland <rol@as2917.net>
>
> This is causing :
> [root@tux ~]# modprobe dell-wmi
> FATAL: Error inserting dell_wmi (/lib/modules/2.6.33-rc2/kernel/drivers/platform/x86/dell-wmi.ko): Input/output error
>
> and
>
> Dec 29 09:54:54 tux kernel: ACPI: WMI: Mapper loaded
> Dec 29 09:54:54 tux kernel: input: Dell WMI hotkeys as /devices/virtual/input/input13
> Dec 29 09:54:54 tux kernel: dell-wmi: Unable to register notify handler - 6
>
> which looks Ok as my machine doesn't seem to have the corresponding stuff.
>
> Anyway, this still needs the changes I sent for wmi.c to avoid the Oops.
>

Yes, Len already has similar patches lined up in acpi-test branch.

--
Dmitry