From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Rolland <rol@as2917.net>
Cc: Len Brown <lenb@kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/2] dell-wmi - properly handle errors returned by wmi_install_notify_handler()
Date: Tue, 29 Dec 2009 01:21:57 -0800 [thread overview]
Message-ID: <20091229092157.GB7805@core.coreip.homeip.net> (raw)
In-Reply-To: <20091229095706.392debfb@tux.DEF.witbe.net>
On Tue, Dec 29, 2009 at 09:57:06AM +0100, Paul Rolland wrote:
> Hello,
>
> On Tue, 29 Dec 2009 00:34:14 -0800
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> > wmi_install_notify_handler() retruns ACPI error codes instead of standard
> > Exxxx error codes and they should not be propagated unchanged to the upper
> > layers.
> >
> > Reported-by: Paul Rolland <rol@as2917.net>
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> Tested-by: Paul Rolland <rol@as2917.net>
>
> This is causing :
> [root@tux ~]# modprobe dell-wmi
> FATAL: Error inserting dell_wmi (/lib/modules/2.6.33-rc2/kernel/drivers/platform/x86/dell-wmi.ko): Input/output error
>
> and
>
> Dec 29 09:54:54 tux kernel: ACPI: WMI: Mapper loaded
> Dec 29 09:54:54 tux kernel: input: Dell WMI hotkeys as /devices/virtual/input/input13
> Dec 29 09:54:54 tux kernel: dell-wmi: Unable to register notify handler - 6
>
> which looks Ok as my machine doesn't seem to have the corresponding stuff.
>
> Anyway, this still needs the changes I sent for wmi.c to avoid the Oops.
>
Yes, Len already has similar patches lined up in acpi-test branch.
--
Dmitry
prev parent reply other threads:[~2009-12-29 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 8:34 [PATCH 1/2] dell-wmi - properly handle errors returned by wmi_install_notify_handler() Dmitry Torokhov
2009-12-29 8:34 ` [PATCH 2/2] hp-wmi " Dmitry Torokhov
2009-12-29 8:56 ` [PATCH 1/2] dell-wmi " Dmitry Torokhov
2009-12-29 8:57 ` Paul Rolland
2009-12-29 9:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091229092157.GB7805@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rol@as2917.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox