From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-pm@lists.linux-foundation.org, linux-acpi@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
Linux PCI <linux-pci@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] [RFC] firewire: Add ohci1394 PCI runtime power management support
Date: Wed, 13 Jan 2010 22:29:57 +0100 [thread overview]
Message-ID: <201001132229.57231.rjw@sisk.pl> (raw)
In-Reply-To: <20100113143312.GA21292@srcf.ucam.org>
On Wednesday 13 January 2010, Matthew Garrett wrote:
> On Wed, Jan 13, 2010 at 01:56:15AM +0100, Stefan Richter wrote:
> > Matthew Garrett wrote:
> > > For sanity purposes, the code ensures that the phy is recent enough to
> > > implement the required functionality. It also ensures that all ports have
> > > the interrupt enabled - a VIA chip I've tested appears to only allow
> > > int_enable to be set on one port at a time, which is inadequate for the
> > > purposes of this code.
> >
> > This adds more extensive use of the link--PHY interface than we ever
> > had, and FireWire stacks in other popular OSs may not have used these
> > features yet too. We will most certainly discover further errata
> > besides the one that you already found.
>
> I don't doubt it. There's almost certainly serious dragons here on some
> hardware.
>
> > > This depends on the PCI runtime PM code, which is not yet upstream. I'm
> > > sending this out now for sanity checking.
> >
> > Is there a convenient source where I can get the infrastructure, so that
> > I could start testing with the few cards that I have?
>
> Rafael posted the latest set to linux-acpi on the 27th of December. I
> don't think there's a set online yet.
In fact, I posted an update last Sunday (Jan 10), that should be included into
the PCI linux-next branch shortly.
The latest patches are here:
http://patchwork.kernel.org/patch/72020/
http://patchwork.kernel.org/patch/72026/
http://patchwork.kernel.org/patch/72019/
http://patchwork.kernel.org/patch/72015/
http://patchwork.kernel.org/patch/72030/
http://patchwork.kernel.org/patch/72021/
http://patchwork.kernel.org/patch/72029/
http://patchwork.kernel.org/patch/72028/
http://patchwork.kernel.org/patch/72027/
Rafael
prev parent reply other threads:[~2010-01-13 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 22:56 [PATCH] [RFC] firewire: Add ohci1394 PCI runtime power management support Matthew Garrett
2010-01-13 0:56 ` Stefan Richter
2010-01-13 14:33 ` Matthew Garrett
2010-01-13 18:45 ` Stefan Richter
2010-01-13 23:04 ` [PATCHv2] " Matthew Garrett
2010-01-14 0:13 ` Stefan Richter
2010-01-13 21:29 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001132229.57231.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mjg59@srcf.ucam.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox