public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: [PATCH 03/12] ACPI: processor: export acpi_get_cpuid()
Date: Mon, 25 Jan 2010 14:40:53 -0700	[thread overview]
Message-ID: <20100125214053.28510.73571.stgit@bob.kio> (raw)
In-Reply-To: <20100125213221.28510.74078.stgit@bob.kio>

Rename static get_cpu_id() to acpi_get_cpuid() and export it.

This change also gives us an opportunity to remove the
#ifndef CONFIG_SMP from processor_driver.c and into a header file
where it properly belongs.

Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/acpi/processor_driver.c |   10 ++++------
 include/acpi/processor.h        |    8 ++++++++
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index d2f285b..404fab4 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -359,10 +359,7 @@ static inline int acpi_processor_remove_fs(struct acpi_device *device)
 
 /* Use the acpiid in MADT to map cpus in case of SMP */
 
-#ifndef CONFIG_SMP
-static int get_cpu_id(acpi_handle handle, int type, u32 acpi_id) { return -1; }
-#else
-
+#ifdef CONFIG_SMP
 static struct acpi_table_madt *madt;
 
 static int map_lapic_id(struct acpi_subtable_header *entry,
@@ -494,7 +491,7 @@ exit:
 	return apic_id;
 }
 
-static int get_cpu_id(acpi_handle handle, int type, u32 acpi_id)
+int acpi_get_cpuid(acpi_handle handle, int type, u32 acpi_id)
 {
 	int i;
 	int apic_id = -1;
@@ -511,6 +508,7 @@ static int get_cpu_id(acpi_handle handle, int type, u32 acpi_id)
 	}
 	return -1;
 }
+EXPORT_SYMBOL_GPL(acpi_get_cpuid);
 #endif
 
 /* --------------------------------------------------------------------------
@@ -577,7 +575,7 @@ static int acpi_processor_get_info(struct acpi_device *device)
 		device_declaration = 1;
 		pr->acpi_id = value;
 	}
-	cpu_index = get_cpu_id(pr->handle, device_declaration, pr->acpi_id);
+	cpu_index = acpi_get_cpuid(pr->handle, device_declaration, pr->acpi_id);
 
 	/* Handle UP system running SMP kernel, with no LAPIC in MADT */
 	if (!cpu0_initialized && (cpu_index == -1) &&
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index d767006..3b66978 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -322,6 +322,14 @@ static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
 
 /* in processor_core.c */
 void acpi_processor_set_pdc(acpi_handle handle);
+#ifdef CONFIG_SMP
+int acpi_get_cpuid(acpi_handle, int type, u32 acpi_id);
+#else
+static inline int acpi_get_cpuid(acpi_handle handle, int type, u32 acpi_id)
+{
+	return -1;
+}
+#endif
 
 /* in processor_throttling.c */
 int acpi_processor_tstate_has_changed(struct acpi_processor *pr);

  parent reply	other threads:[~2010-01-25 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 21:40 [PATCH 00/12] ACPI: processor driver vs. core Alex Chiang
2010-01-25 21:40 ` [PATCH 01/12] ACPI: processor: mv processor_core.c processor_driver.c Alex Chiang
2010-01-25 21:40 ` [PATCH 02/12] ACPI: processor: mv processor_pdc.c processor_core.c Alex Chiang
2010-01-25 21:40 ` Alex Chiang [this message]
2010-01-25 21:40 ` [PATCH 04/12] ACPI: processor: move acpi_get_cpuid into processor_core.c Alex Chiang
2010-01-25 21:41 ` [PATCH 05/12] ACPI: processor: add internal processor_physically_present() Alex Chiang
2010-01-25 21:41 ` [PATCH 06/12] ACPI: processor: remove early _PDC optin quirks Alex Chiang
2010-01-25 21:41 ` [PATCH 07/12] ACPI: processor: driver doesn't need to evaluate _PDC Alex Chiang
2010-01-25 21:41 ` [PATCH 08/12] ACPI: processor: refactor internal map_lapic_id() Alex Chiang
2010-01-25 21:41 ` [PATCH 09/12] ACPI: processor: refactor internal map_x2apic_id() Alex Chiang
2010-01-25 21:41 ` [PATCH 10/12] ACPI: processor: refactor internal map_lsapic_id() Alex Chiang
2010-01-25 22:22   ` David Rientjes
2010-01-25 22:46     ` Alex Chiang
2010-01-25 21:41 ` [PATCH 11/12] ACPI: processor: push file static MADT pointer into internal map_madt_entry() Alex Chiang
2010-01-25 21:41 ` [PATCH 12/12] ACPI: processor core: style and sparse cleanups Alex Chiang
2010-02-02 23:17 ` [PATCH 00/12] ACPI: processor driver vs. core Alex Chiang
2010-02-03  1:51   ` Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100125214053.28510.73571.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox