From: Alex Chiang <achiang@hp.com>
To: David Rientjes <rientjes@google.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] ACPI: processor: refactor internal map_lsapic_id()
Date: Mon, 25 Jan 2010 15:46:28 -0700 [thread overview]
Message-ID: <20100125224628.GB2828@grease.ALLEYCAT> (raw)
In-Reply-To: <alpine.DEB.2.00.1001251421440.27862@chino.kir.corp.google.com>
Hi David,
* David Rientjes <rientjes@google.com>:
> On Mon, 25 Jan 2010, Alex Chiang wrote:
>
> > diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> > index 9213f95..ec5989c 100644
> > --- a/drivers/acpi/processor_core.c
> > +++ b/drivers/acpi/processor_core.c
> > @@ -83,27 +83,17 @@ static int map_lsapic_id(struct acpi_subtable_header *entry,
> > {
> > struct acpi_madt_local_sapic *lsapic =
> > (struct acpi_madt_local_sapic *)entry;
> > - u32 tmp = (lsapic->id << 8) | lsapic->eid;
> >
> > - /* Only check enabled APICs*/
> > if (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))
> > return 0;
> >
> > - /* Device statement declaration type */
> > if (device_declaration) {
> > - if (entry->length < 16)
> > - printk(KERN_ERR PREFIX
> > - "Invalid LSAPIC with Device type processor (SAPIC ID %#x)\n",
> > - tmp);
>
> Why drop this error message?
It didn't seem to add any value.
If BIOS declares a processor with the Device statement in ACPI
and it has an invalid length, there's nothing that a user can do
about it.
Arguably, the message might be useful during internal platform
bringup (or new firmware validation), but even that's a hard sell
to me, since one of the first things a bringup engineer would
notice would be missing CPUs, and it wouldn't take that long to
realize that firmware was broken; why make upstream carry around
extra baggage for internal firmware debugging?
But I don't have a strong opinion here. If folks think that
message is useful, I can respin leaving it in.
Thanks,
/ac
next prev parent reply other threads:[~2010-01-25 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 21:40 [PATCH 00/12] ACPI: processor driver vs. core Alex Chiang
2010-01-25 21:40 ` [PATCH 01/12] ACPI: processor: mv processor_core.c processor_driver.c Alex Chiang
2010-01-25 21:40 ` [PATCH 02/12] ACPI: processor: mv processor_pdc.c processor_core.c Alex Chiang
2010-01-25 21:40 ` [PATCH 03/12] ACPI: processor: export acpi_get_cpuid() Alex Chiang
2010-01-25 21:40 ` [PATCH 04/12] ACPI: processor: move acpi_get_cpuid into processor_core.c Alex Chiang
2010-01-25 21:41 ` [PATCH 05/12] ACPI: processor: add internal processor_physically_present() Alex Chiang
2010-01-25 21:41 ` [PATCH 06/12] ACPI: processor: remove early _PDC optin quirks Alex Chiang
2010-01-25 21:41 ` [PATCH 07/12] ACPI: processor: driver doesn't need to evaluate _PDC Alex Chiang
2010-01-25 21:41 ` [PATCH 08/12] ACPI: processor: refactor internal map_lapic_id() Alex Chiang
2010-01-25 21:41 ` [PATCH 09/12] ACPI: processor: refactor internal map_x2apic_id() Alex Chiang
2010-01-25 21:41 ` [PATCH 10/12] ACPI: processor: refactor internal map_lsapic_id() Alex Chiang
2010-01-25 22:22 ` David Rientjes
2010-01-25 22:46 ` Alex Chiang [this message]
2010-01-25 21:41 ` [PATCH 11/12] ACPI: processor: push file static MADT pointer into internal map_madt_entry() Alex Chiang
2010-01-25 21:41 ` [PATCH 12/12] ACPI: processor core: style and sparse cleanups Alex Chiang
2010-02-02 23:17 ` [PATCH 00/12] ACPI: processor driver vs. core Alex Chiang
2010-02-03 1:51 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125224628.GB2828@grease.ALLEYCAT \
--to=achiang@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox