From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver_mask Date: Mon, 8 Feb 2010 22:38:53 -0200 Message-ID: <20100209003853.GD21680@khazad-dum.debian.net> References: <1265567528-1180-1-git-send-email-cascardo@holoscopio.com> <20100208155059.eed393a6.akpm@linux-foundation.org> <20100209000810.GC1420@holoscopio.com> <20100208162153.b317e434.akpm@linux-foundation.org> <20100209003131.GE1420@holoscopio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out2.smtp.messagingengine.com ([66.111.4.26]:46967 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab0BIAi4 (ORCPT ); Mon, 8 Feb 2010 19:38:56 -0500 Content-Disposition: inline In-Reply-To: <20100209003131.GE1420@holoscopio.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thadeu Lima de Souza Cascardo Cc: Andrew Morton , linux-acpi@vger.kernel.org, Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org On Mon, 08 Feb 2010, Thadeu Lima de Souza Cascardo wrote: > You've fixed the hotkey_poll_setup to a hotkey_poll_setup_safe that has > just been added by a patch of mine to the function brightness_init. The > same has not been done to the call that has been added to the function > volume_init. Andrew said it didn't matter for the __init functions in thinkpad-acpi, and he is correct. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh