public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver_mask
Date: Tue, 9 Feb 2010 23:28:22 -0200	[thread overview]
Message-ID: <20100210012821.GA7710@khazad-dum.debian.net> (raw)
In-Reply-To: <20100210001651.GA1422@holoscopio.com>

On Tue, 09 Feb 2010, Thadeu Lima de Souza Cascardo wrote:
> Sorry for the delay. Takes a while to build a kernel in my old notebook
> with a not-so-large config.

Heh, I know how you feel.  Maybe you can use distcc to offload the worst of
the work to a more powerful box?

> It works nice for me. This was a fix that has crossed my mind, but since
> other init was doing the other way (hotkey_init), I did prefer that too.
> Anyway, your way is cleaner and the right way.  :-)

hotkey_* kinda "owns" the event interface, so it is allowed some liberties I
try to avoid in the other parts of the driver :)

> Tested-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Thank you.  I will forward it to Len.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

      reply	other threads:[~2010-02-10  1:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 18:32 [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver_mask Thadeu Lima de Souza Cascardo
2010-02-08 23:50 ` Andrew Morton
2010-02-09  0:08   ` Thadeu Lima de Souza Cascardo
2010-02-09  0:21     ` Andrew Morton
2010-02-09  0:31       ` Thadeu Lima de Souza Cascardo
2010-02-09  0:38         ` Henrique de Moraes Holschuh
2010-02-09  0:37 ` Henrique de Moraes Holschuh
2010-02-09  1:37   ` Henrique de Moraes Holschuh
2010-02-10  0:16     ` Thadeu Lima de Souza Cascardo
2010-02-10  1:28       ` Henrique de Moraes Holschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210012821.GA7710@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=akpm@linux-foundation.org \
    --cc=cascardo@holoscopio.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox