From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: akpm@linux-foundation.org, linux-acpi@vger.kernel.org,
arekm@maven.pl, feng.tang@intel.com, flinco@libero.it,
mad_soft@inbox.ru, rjw@sisk.pl
Subject: Re: [patch 7/7] acpi: remove old blacklist entries
Date: Wed, 17 Feb 2010 18:31:08 +0000 [thread overview]
Message-ID: <20100217183108.GA23189@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1002171122140.4135@localhost.localdomain>
On Wed, Feb 17, 2010 at 01:24:58PM -0500, Len Brown wrote:
> On Wed, 17 Feb 2010, Matthew Garrett wrote:
> > We seem to have no good history of where these blacklist entries came
> > from, and we know that at least one of them is actively harmful. Perhaps
> > replace them with a debug statement on affected machines telling people
> > what they need to pass to restore the blacklist behaviour, and to let us
> > know if it's necessary?
>
> Actually, it wasn't actively harmful until we broke "acpi=ht".
> Indeed, it was actively helpful in pointing out that regression:-)
The machines in question are falling back to apm, so probably losing
some level of powersaving support. I'd say that's harmful :)
> The other entries in today's acpi_dmi_table[] are less clear
> and should probably be modified only with some care...
At least one of them covers a single submodel in a range, despite them
all running the same BIOS. I'd really lean towards them being bogus at
this stage of the game.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-02-17 18:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:37 [patch 7/7] acpi: remove old blacklist entries akpm
2010-02-03 23:04 ` Henrique de Moraes Holschuh
2010-02-16 7:53 ` Len Brown
2010-02-16 8:19 ` Len Brown
2010-02-16 15:40 ` Matthew Garrett
2010-02-17 2:49 ` Len Brown
2010-02-17 14:32 ` Matthew Garrett
2010-02-17 18:24 ` Len Brown
2010-02-17 18:31 ` Matthew Garrett [this message]
2010-02-17 19:43 ` Henrique de Moraes Holschuh
2010-02-17 21:23 ` Len Brown
2010-02-17 21:28 ` Matthew Garrett
2010-02-19 5:44 ` Len Brown
2010-02-19 5:53 ` [PATCH 1/2] ACPI: remove "acpi=ht" DMI blacklist Len Brown
2010-02-19 5:55 ` [patch 2/2] ACPI: delete the "acpi=ht" boot option Len Brown
2010-02-23 11:11 ` [patch 7/7] acpi: remove old blacklist entries Thomas Renninger
2010-03-14 20:35 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217183108.GA23189@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=arekm@maven.pl \
--cc=feng.tang@intel.com \
--cc=flinco@libero.it \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).