Re: [patch 7/7] acpi: remove old blacklist entries

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Wed, Feb 17, 2010 at 04:23:12PM -0500, Len Brown wrote:
> On Wed, 17 Feb 2010, Matthew Garrett wrote:
> > The machines in question are falling back to apm, so probably losing 
> > some level of powersaving support. I'd say that's harmful :)
> 
> The system at hand is the Asus P2B-DS, a Dual Pentium III.
> APM is not SMP safe, and was not deployed on SMP motherboards.
> My expectation is that it is perfectly fine running in MPS
> mode rather than ACPI mode, as it has been running that way
> since 2003.  My expectation is that when running in ACPI mode,
> the only thing the user will notice is that the power button
> is software controlled.

So the APM idle loop won't have been used? I was under the impression 
that C1 was preferable to just calling hlt, but I'll admit to having no 
idea if that's true for the PIII. I'd also have expected there to be at 
least S1, so ACPI would be a functional improvement.

> > At least one of them covers a single submodel in a range, despite them 
> > all running the same BIOS. I'd really lean towards them being bogus at 
> > this stage of the game.
> 
> While I too vote for consistency and less cruft is better,
> I'd like to keep the acpi_ht issue at hand apart from the
> inconsistency in old thinkpad BIOS DMI list issue; as they
> are logically independent.

They're similar in that we have absolutely no idea why these entries are 
present, potentially resulting in us reducing the functionality of 
machines that would otherwise work happily.

-- 
Matthew Garrett | mjg59@srcf.ucam.org