From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen
Date: Fri, 19 Feb 2010 12:20:56 +0100 [thread overview]
Message-ID: <201002191220.56517.trenn@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1002190138310.24628@localhost.localdomain>
On Friday 19 February 2010 07:39:43 Len Brown wrote:
> Thomas,
>
> What good things happen after this patch that didn't happen before it?
The guy sees a valid temperature, in /proc-/sys and also in the
corresponding X-apps (which his original complaints were).
The thermal zone has a valid passive trip point (95 C), which now is
active again.
He reported this as a regression, let me double check:
Oh dear..., _CRT doesn't return anything for Windows 2006
(or newer, not defined Windowses) -> broken trip point.
There is a Linux workaround (which does not work anymore,
this probably was the reason for the regression -> OSI!=Linux),
which make _CRT return a valid trip point like on old Windowses.
So this makes the behavior more "latest Windows OS" like.
Hmm, depends whether Windows still takes the thermal zone into
account if _CRT is not available or invalid.
The fact that a valid _HOT trip point is only exported on latest
Windowses, hardens the guess that Windows also serves this
thermal zone with an invalid critical trip point.
It looks like the (TPOS == 0x40) thermal workarounds wants to avoid
thermal shutdowns (critical) in case 100 C are reached and change it
into a (debug?) message (_HOT) on latest Windowses.
Thomas
Related ASL output:
If (_OSI ("Linux"))
{
Store (One, LINX)
Store (0x80, OSTB)
Store (0x80, TPOS)
}
If (_OSI ("Windows 2006"))
{
Store (0x40, OSTB)
Store (0x40, TPOS)
}
...
Name (TPC, 0x64)
Method (_HOT, 0, Serialized)
{
If (LEqual (TPOS, 0x40))
{
Return (Add (0x0AAC, Multiply (TPC, 0x0A)))
}
}
Method (_CRT, 0, Serialized)
{
If (LNotEqual (TPOS, 0x40))
{
Return (Add (0x0AAC, Multiply (TPC, 0x0A)))
}
}
next prev parent reply other threads:[~2010-02-19 11:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:55 [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Thomas Renninger
2010-02-16 21:55 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requirement Thomas Renninger
2010-02-19 6:39 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen Len Brown
2010-02-19 11:20 ` Thomas Renninger [this message]
2010-02-19 16:20 ` Len Brown
2010-02-19 16:37 ` Thomas Renninger
2010-02-20 4:57 ` Len Brown
2010-02-20 9:50 ` Thomas Renninger
2010-02-20 10:15 ` Thomas Renninger
2010-02-19 6:34 ` [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Len Brown
2010-02-19 7:34 ` Len Brown
2010-02-20 10:20 ` [PATCH] " Thomas Renninger
2010-02-20 10:42 ` Thomas Renninger
2010-02-20 10:44 ` Thomas Renninger
2010-02-21 2:51 ` Zhang Rui
[not found] ` <201002220002.49341.trenn@suse.de>
2010-02-22 1:33 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002191220.56517.trenn@suse.de \
--to=trenn@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox