From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, rui.zhang@intel.com
Subject: Re: [PATCH] ACPI video: Be more liberal in validating _BQC behaviour
Date: Fri, 19 Feb 2010 13:54:31 +0000 [thread overview]
Message-ID: <20100219135431.GA29434@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1002190140230.24628@localhost.localdomain>
On Fri, Feb 19, 2010 at 01:40:47AM -0500, Len Brown wrote:
> Matthew,
>
> Is there a life failure someplace (eg. bugzilla) that works after this
> patch?
My system statically initialises the variable containing the current
brightness to 100, but doesn't include 100 in the list of valid
brightnesses. Right now this causes us to stop believing _BQC. However,
the enxt thing we do is set the brightness to maximum anyway - at this
point _BQC will now return a correct value. So it makes sense to ignore
_BQC failures until we've set a valid value. If it continues to give
invalid results then we can invalidate it and just use our internal
state.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-02-19 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:53 [PATCH] ACPI video: Be more liberal in validating _BQC behaviour Matthew Garrett
2010-02-19 6:40 ` Len Brown
2010-02-19 13:54 ` Matthew Garrett [this message]
2010-02-22 1:51 ` Zhang Rui
2010-02-22 2:06 ` Matthew Garrett
2010-02-23 6:29 ` Zhang Rui
2010-02-22 17:24 ` Thomas Renninger
2010-02-22 17:38 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219135431.GA29434@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox