From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen
Date: Fri, 19 Feb 2010 17:37:49 +0100 [thread overview]
Message-ID: <201002191737.49957.trenn@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1002191108590.4030@localhost.localdomain>
On Friday 19 February 2010 17:20:51 Len Brown wrote:
> > > What good things happen after this patch that didn't happen before it?
> >
> > The guy sees a valid temperature, in /proc-/sys and also in the
> > corresponding X-apps (which his original complaints were).
> >
> > The thermal zone has a valid passive trip point (95 C), which now is
> > active again.
>
> I understand the 1st patch to not disqualify a TZ if it has
> a bogus _CRT. That would make a TZ show up rather than
> get discarded. If that patch compiled cleanly, I'd apply it...
>
> I don't understand this patch to scan a TZ for trip points
> and print out a kernel warning about a firmware bug
> for TZ's which have none, and disqualify those TZ's.
> That isn't going to make temperature available when it
> was not already available. That is going to add an additional
> kernel message about a firmware bug we can't fix,
Hmm, Firmware bugs which we can't fix and can't even work around always
should at least end up in a firmware bug/warning message.
> and could actually delete a thermal zone with a working temperature
> that used to be present, no?
Not really. At least not worse than before.
Before my previous patch every thermal zone without a valid critical
trip point was discarded with an error message.
Now you need at least one.
My patch sticks to the spec and only discards the thermal zone if there
is no trip point at all. In this case you want to throw a (firmware bug)
message as something is obviously wrong.
Thomas
next prev parent reply other threads:[~2010-02-19 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:55 [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Thomas Renninger
2010-02-16 21:55 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requirement Thomas Renninger
2010-02-19 6:39 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen Len Brown
2010-02-19 11:20 ` Thomas Renninger
2010-02-19 16:20 ` Len Brown
2010-02-19 16:37 ` Thomas Renninger [this message]
2010-02-20 4:57 ` Len Brown
2010-02-20 9:50 ` Thomas Renninger
2010-02-20 10:15 ` Thomas Renninger
2010-02-19 6:34 ` [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Len Brown
2010-02-19 7:34 ` Len Brown
2010-02-20 10:20 ` [PATCH] " Thomas Renninger
2010-02-20 10:42 ` Thomas Renninger
2010-02-20 10:44 ` Thomas Renninger
2010-02-21 2:51 ` Zhang Rui
[not found] ` <201002220002.49341.trenn@suse.de>
2010-02-22 1:33 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002191737.49957.trenn@suse.de \
--to=trenn@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox