From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen
Date: Sat, 20 Feb 2010 10:50:27 +0100 [thread overview]
Message-ID: <201002201050.28035.trenn@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1002192353591.4030@localhost.localdomain>
On Saturday 20 February 2010 05:57:30 am Len Brown wrote:
> On Fri, 19 Feb 2010, Thomas Renninger wrote:
> i agree with the 1st patch,
> as I said, if it built cleanly (hint hint) I'd apply it.
Coming soon.
> > Now you need at least one.
> >
> > My patch sticks to the spec and only discards the thermal zone if there
> > is no trip point at all. In this case you want to throw a (firmware bug)
> > message as something is obviously wrong.
>
> This is the non-obvious part.
> Yes, a thermal zone that has no trip point doesn't follow the spec.
> I don't know if any exist or not, but I don't see any harm if they do.
> I think it would be dandy for linuxfirmware test kit to look
> for this BIOS issue, but I don't see how the user is helped
> if the kernel looks for it. All the get is an additional
> kernel message and perhaps the loss of the ability to
> tell the temperature when perhaps they could before.
> That doesn't sound like a step forward.
Thinking about this again:
I fully agree.
Just ignore the 2nd patch.
Thanks,
Thomas
next prev parent reply other threads:[~2010-02-20 9:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:55 [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Thomas Renninger
2010-02-16 21:55 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requirement Thomas Renninger
2010-02-19 6:39 ` [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen Len Brown
2010-02-19 11:20 ` Thomas Renninger
2010-02-19 16:20 ` Len Brown
2010-02-19 16:37 ` Thomas Renninger
2010-02-20 4:57 ` Len Brown
2010-02-20 9:50 ` Thomas Renninger [this message]
2010-02-20 10:15 ` Thomas Renninger
2010-02-19 6:34 ` [PATCH 1/2] ACPI thermal: Don't invalidate thermal zone if critical trip point is bad Len Brown
2010-02-19 7:34 ` Len Brown
2010-02-20 10:20 ` [PATCH] " Thomas Renninger
2010-02-20 10:42 ` Thomas Renninger
2010-02-20 10:44 ` Thomas Renninger
2010-02-21 2:51 ` Zhang Rui
[not found] ` <201002220002.49341.trenn@suse.de>
2010-02-22 1:33 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002201050.28035.trenn@suse.de \
--to=trenn@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox