Re: [PATCH 2/2] ACPI thermal: Check for thermal zone requiremen

Thomas Renninger
2010-02-19T16:37:51Z

On Friday 19 February 2010 17:20:51 Len Brown wrote:
> > > What good things happen after this patch that didn't happen before it?
> >
> > The guy sees a valid temperature, in /proc-/sys and also in the
> > corresponding X-apps (which his original complaints were).
> >
> > The thermal zone has a valid passive trip point (95 C), which now is
> > active again.
>
> I understand the 1st patch to not disqualify a TZ if it has
> a bogus _CRT. That would make a TZ show up rather than
> get discarded. If that patch compiled cleanly, I'd apply it...
>
> I don't understand this patch to scan a TZ for trip points
> and print out a kernel warning about a firmware bug
> for TZ's which have none, and disqualify those TZ's.
> That isn't going to make temperature available when it
> was not already available. That is going to add an additional
> kernel message about a firmware bug we can't fix,
Hmm, Firmware bugs which we can't fix and can't even work around always
should at least end up in a firmware bug/warning message.

> and could actually delete a thermal zone with a working temperature
> that used to be present, no?
Not really. At least not worse than before.
Before my previous patch every thermal zone without a valid critical
trip point was discarded with an error message.
Now you need at least one.

My patch sticks to the spec and only discards the thermal zone if there
is no trip point at all. In this case you want to throw a (firmware bug)
message as something is obviously wrong.

Thomas