From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: Corentin Chary <corentin.chary@gmail.com>,
linux-pci@vger.kernel.org,
linux acpi <linux-acpi@vger.kernel.org>
Subject: Re: disabling "rfkill hotplug" on newer eeepc-laptop models
Date: Sat, 20 Feb 2010 15:44:15 +0000 [thread overview]
Message-ID: <20100220154415.GA25161@srcf.ucam.org> (raw)
In-Reply-To: <4B7FDAAD.1040704@tuffmail.co.uk>
On Sat, Feb 20, 2010 at 12:50:53PM +0000, Alan Jenkins wrote:
> 1. checking PCI config space, to see whether the device is really absent
> before we mark it as unplugged.
> 2. a generic mechanism which would replace the current eeepc-specific code.
The generic mechanism will become necessary with .34 anyway, as soon as
the PCI runtime power management code lands. It'll be taking the
notification handlers for these devices.
I think we effectively need to move some of the acpiphp code and make it
generic. These shouldn't be exposed as hotplug slots, but if we receive
a rescan notification and the device is no longer there then it's pretty
obvious that we need to remove it...
On the other hand, your patch looks fine for the immediate issue.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-02-20 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 12:50 disabling "rfkill hotplug" on newer eeepc-laptop models Alan Jenkins
2010-02-20 15:44 ` Matthew Garrett [this message]
2010-02-22 14:10 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220154415.GA25161@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=corentin.chary@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox