From: Dave Jones <davej@redhat.com>
To: venkatesh.pallipadi@intel.com
Cc: Ingo Molnar <mingo@elte.hu>, H Peter Anvin <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@gmail.com>
Subject: Re: [patch 2/2] x86: Manage ENERGY_PERF_BIAS based on cpufreq governor - v2
Date: Thu, 4 Mar 2010 18:27:56 -0500 [thread overview]
Message-ID: <20100304232756.GA13895@redhat.com> (raw)
In-Reply-To: <20100304231547.798303000@intel.com>
On Thu, Mar 04, 2010 at 03:14:56PM -0800, Venki Pallipadi wrote:
> + if (!strncmp(gov->name, "performance", strlen("performance")))
> + epb_val = ENERGY_PERF_BIAS_PERF;
> + else if (!strncmp(gov->name, "powersave", strlen("powersave")))
> + epb_val = ENERGY_PERF_BIAS_POWER;
> + else
> + epb_val = ENERGY_PERF_BIAS_ONDEMAND;
> +
> + set_epb_on_cpu(epb_val, cpu);
> + return 0;
hardcoding a list of cpufreq governors is kinda icky, but I don't have
a better solution. We'll just have to be mindful of it if we ever
get around to finally making performance/powersave personalities
of ondemand as was discussed years ago.
What if the governor is set to 'userspace' ?
powernowd/cpufreqd are sort of ondemand-done-in-userspace, but there
may also be other userspace governors we don't know about.
I suppose it's not catastrophic..
Dave
next prev parent reply other threads:[~2010-03-04 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 23:14 [patch 0/2] Support for IA32_ENERGY_PERF_BIAS MSR - v2 venkatesh.pallipadi
2010-03-04 23:14 ` [patch 1/2] x86: Look for IA32_ENERGY_PERF_BIAS support " venkatesh.pallipadi
2010-06-04 3:22 ` [PATCH] x86: Look for IA32_ENERGY_PERF_BIAS support - v3 Len Brown
2010-03-04 23:14 ` [patch 2/2] x86: Manage ENERGY_PERF_BIAS based on cpufreq governor - v2 venkatesh.pallipadi
2010-03-04 23:27 ` Dave Jones [this message]
2010-03-04 23:34 ` Pallipadi, Venkatesh
2010-06-04 3:38 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304232756.GA13895@redhat.com \
--to=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@gmail.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).