From: Myron Stowe <myron.stowe@hp.com>
To: minyard@acm.org
Cc: linux-acpi@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, lenb@kernel.org
Subject: [PATCH v2 1/3] ipmi: Raise precedence of PNP based discovery mechanisms (ACPI, PCI)
Date: Sat, 13 Mar 2010 11:13:42 -0700 [thread overview]
Message-ID: <20100313181342.20614.72981.stgit@bob.kio> (raw)
In-Reply-To: <20100313180121.20614.92547.stgit@bob.kio>
This raises the precedence of PNP discovery mechanisms, ACPI and PCI,
above SMBIOS and SPMI as indicated by Appendix C1 of the IPMI
specification.
Reference: IPMI - Intelligent Platform Management Interface Specification
v2.0, Document Revision 1.0, 05.05.2005 Markup
Appendix C1 - Locating IPMI System Interfaces via SMBIOS Tables
"Note that the settings that this structure reports may be over-
ridden by `Plug-and-Play' reassignment by the OS. Therefore, this
structure should be used only when the interface cannot be
discovered via `Plug-and-Play' discovery mechanisms incorporated
in interfaces such as PCI and ACPI."
Signed-off-by: Myron Stowe <myron.stowe@hp.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 176f175..86a7dd7 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3197,13 +3197,6 @@ static __devinit int init_ipmi_si(void)
hardcode_find_bmc();
-#ifdef CONFIG_DMI
- dmi_find_bmc();
-#endif
-
-#ifdef CONFIG_ACPI
- spmi_find_bmc();
-#endif
#ifdef CONFIG_ACPI
pnp_register_driver(&ipmi_pnp_driver);
#endif
@@ -3220,6 +3213,14 @@ static __devinit int init_ipmi_si(void)
of_register_platform_driver(&ipmi_of_platform_driver);
#endif
+#ifdef CONFIG_DMI
+ dmi_find_bmc();
+#endif
+
+#ifdef CONFIG_ACPI
+ spmi_find_bmc();
+#endif
+
if (si_trydefaults) {
mutex_lock(&smi_infos_lock);
if (list_empty(&smi_infos)) {
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
next prev parent reply other threads:[~2010-03-13 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 18:13 [PATCH v2 0/3] ipmi: discovery precedence and update core driver with dev_printk Myron Stowe
2010-03-13 18:13 ` Myron Stowe [this message]
2010-03-15 1:48 ` [PATCH v2 1/3] ipmi: Raise precedence of PNP based discovery mechanisms (ACPI, PCI) ykzhao
2010-03-16 15:03 ` Myron Stowe
2010-03-13 18:13 ` [PATCH v2 2/3] ipmi: Convert tracking of the ACPI device pointer to a PNP device Myron Stowe
2010-03-15 1:50 ` ykzhao
2010-03-13 18:13 ` [PATCH v2 3/3] ipmi: Update driver to use 'dev_printk()' and its constructs Myron Stowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313181342.20614.72981.stgit@bob.kio \
--to=myron.stowe@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox