Re: [PATCH v2 1/3] ipmi: Raise precedence of PNP based discovery mechanisms (ACPI, PCI)

ykzhao
2010-03-15T01:50:49Z

On Sun, 2010-03-14 at 02:13 +0800, Myron Stowe wrote:
> This raises the precedence of PNP discovery mechanisms, ACPI and PCI,
> above SMBIOS and SPMI as indicated by Appendix C1 of the IPMI
> specification.
>
> Reference: IPMI - Intelligent Platform Management Interface Specification
> v2.0, Document Revision 1.0, 05.05.2005 Markup
>
> Appendix C1 - Locating IPMI System Interfaces via SMBIOS Tables
> "Note that the settings that this structure reports may be over-
> ridden by `Plug-and-Play' reassignment by the OS. Therefore, this
> structure should be used only when the interface cannot be
> discovered via `Plug-and-Play' discovery mechanisms incorporated
> in interfaces such as PCI and ACPI."

Hi,
The SPMI detection mechanism belongs to one of two ACPI detection
mechanisms.
Can we put it before DMI detection mechanism?

Anyway, it is right that the pnp discovery mechanism has higher
priority than PCI/SPMI/SMBIOS.

Thanks.
Yakui
>
> Signed-off-by: Myron Stowe <myron.stowe@hp.com>
> ---
>
> drivers/char/ipmi/ipmi_si_intf.c | 15 ++++++++-------
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 176f175..86a7dd7 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3197,13 +3197,6 @@ static __devinit int init_ipmi_si(void)
>
> hardcode_find_bmc();
>
> -#ifdef CONFIG_DMI
> - dmi_find_bmc();
> -#endif
> -
> -#ifdef CONFIG_ACPI
> - spmi_find_bmc();
> -#endif
> #ifdef CONFIG_ACPI
> pnp_register_driver(&ipmi_pnp_driver);
> #endif
> @@ -3220,6 +3213,14 @@ static __devinit int init_ipmi_si(void)
> of_register_platform_driver(&ipmi_of_platform_driver);
> #endif
>
> +#ifdef CONFIG_DMI
> + dmi_find_bmc();
> +#endif
> +
> +#ifdef CONFIG_ACPI
> + spmi_find_bmc();
> +#endif
> +
> if (si_trydefaults) {
> mutex_lock(&smi_infos_lock);
> if (list_empty(&smi_infos)) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html