From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
Pete Zaitcev <zaitcev@redhat.com>,
Thomas Renninger <trenn@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/PCI: ignore Consumer/Producer bit and parse additional _CRS resources
Date: Fri, 19 Mar 2010 13:38:48 -0700 [thread overview]
Message-ID: <20100319133848.35465d9a@jbarnes-piketon> (raw)
In-Reply-To: <20100316201134.24527.87006.stgit@bob.kio>
On Tue, 16 Mar 2010 14:11:34 -0600
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> We previously used only resources marked "Producer," i.e., those the bridge
> forwards downstream. But BIOSes haven't used that bit consistently, so it's
> useless. For bridge devices, we have to assume *all* ACPI resources are
> forwarded downstream. Non-Producer bridge resources typically appear in
> PCI config space and are not described in ACPI.
>
> In addition to ACPI_RESOURCE_TYPE_ADDRESS{16,32,64}, parse these types:
>
> ACPI_RESOURCE_TYPE_IO
> ACPI_RESOURCE_TYPE_FIXED_IO
> ACPI_RESOURCE_TYPE_MEMORY24
> ACPI_RESOURCE_TYPE_MEMORY32
> ACPI_RESOURCE_TYPE_FIXED_MEMORY32
> ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64
>
> This basically reimplements what drivers/pnp/pnpacpi/rsparser.c already
> does, and I plan to take advantage of that, but we're not quite ready to
> do it yet because it will require converting pci_root.c from an ACPI
> driver to a PNP driver.
>
> This is a possible fix for http://bugzilla.kernel.org/show_bug.cgi?id=15533
> reported by Pete Zaitcev <zaitcev@redhat.com>.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
>
Applied to my for-linus tree, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-03-19 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 20:11 [PATCH] x86/PCI: pci=use_crs regression fix Bjorn Helgaas
2010-03-16 20:11 ` [PATCH] x86/PCI: ignore Consumer/Producer bit and parse additional _CRS resources Bjorn Helgaas
2010-03-19 20:38 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319133848.35465d9a@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=trenn@suse.de \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox